From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfram Sang Subject: Re: [PATCH v2] i2c: rk3x: fix bug that cause measured high_ns doesn't meet I2C spec Date: Thu, 4 Dec 2014 20:03:43 +0100 Message-ID: <20141204190342.GM7944@katana> References: <1415261514-4051-1-git-send-email-addy.ke@rock-chips.com> <1417574237-4328-1-git-send-email-addy.ke@rock-chips.com> <20141203111518.GB1039@katana> <20141204184046.GL7944@katana> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="AQYPrgrEUc/1pSX1" Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Doug Anderson Cc: Addy Ke , Max Schwarz , Heiko =?utf-8?Q?St=C3=BCbner?= , Olof Johansson , Rob Herring , Pawel Moll , Ian Campbell , Kumar Gala , "linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "open list:ARM/Rockchip SoC..." , Eddie Cai , Jianqun Xu , Tao Huang , Chris , =?utf-8?B?5aea5pm65oOF?= , han jiang , Kever Yang , Lin Huang , caesar List-Id: linux-i2c@vger.kernel.org --AQYPrgrEUc/1pSX1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > > New binding should have the "-ns" suffix, right? So, I'd vote to add the > > suffix to the new bindings and deprecate the ones used in the designware > > driver: "i2c-scl-rising-time-ns" and "i2c-scl-falling-time-ns" > > > > It might be a little more work now, but it will help us in the future, > > because it is the correct way to do it. >=20 > OK, that sounds fair. You're OK with my proposal otherwise? Yes. > Are you looking for Addy or me to submit a patch supporting the "-ns" > suffix on the Designware i2c driver, or should we just use the "-ns" > suffix in the Rockchip driver and assume someone will later add > support for the new binding in the Designware i2c driver? I'd be really happy if you can do it. I'd love to have consistency right away. --AQYPrgrEUc/1pSX1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJUgLAOAAoJEBQN5MwUoCm2MZoP/2+ZtwoRTOxH7xJMmnmngJTI y4CXTCTr8ES9GRvGizq0oeMS6/B0JCVKHgwAuD99WXXFM9oRuVwP1XpiuJ2D9AZv 6h0kA4My4RqS0G+HDWvvVTsgNIisBg0X3yY20Me3iE4dG1DRTKPSf4L8UDRaBIkG 86xF1lmJqDHCrdGEoGeL0GPkdQwx5JZuryUf1xJdG6A64lYWljf6jCPbT7Z5JzoL 6kBTSCDmS2hnrEs+iCXjelzsv/DRZNZaQnCxUbhS+nPMkJJ+zU6tm98OQsTaURB2 vg4NVXpiOlSp9bEeTYe5HlYZQzHucdMlsv/s09BBdh8nrVnrcUQx4oC526+8165Z P4dNfiAbZjR+bVcouSOMcqkh6QJFqtaBdN1v//7rI83iQiNw3onpxFDsLhZsjESA h4YRBLcyXHv6qQJos+BMgE7FvTkCuV2C34bEnzVHnVvanquNvCx4cPe1oAKwJpKG OLvMQH6wdpp9wXNXiVMvWLoQBgLbkFgw1McVg+KV01ah1E6Er3YxFL0u/blJYJyC /6urwqUrA1VJCf9XyvPWlKpJjSv8EpWK4VyY9fbHUt88hkLEWQQPem7Yv0QNhZ41 bVYbliN5VcopeBucrNhsPlEjxOO68EeWA1JqhyLmyAdbI6eqysA+6ml807QOEe2G joRwygOCCnlnq3Fw9j5h =nKGV -----END PGP SIGNATURE----- --AQYPrgrEUc/1pSX1--