linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa@the-dreams.de>
To: kbuild test robot <fengguang.wu@intel.com>
Cc: kbuild-all@01.org, Lars Poeschel <poeschel@lemonage.de>,
	linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [wsa:i2c/quirks 10/11] drivers/i2c/busses/i2c-viperboard.c:357:27: sparse: symbol 'vprbrd_quirks' was not declared. Should it be static?
Date: Thu, 8 Jan 2015 19:38:00 +0100	[thread overview]
Message-ID: <20150108183800.GC29629@katana> (raw)
In-Reply-To: <201501090239.gPJgrJIE%fengguang.wu@intel.com>

[-- Attachment #1: Type: text/plain, Size: 2634 bytes --]

On Fri, Jan 09, 2015 at 02:07:53AM +0800, kbuild test robot wrote:
> tree:   git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux i2c/quirks
> head:   b1d39af8ae21f4930854b0656aa83a83fd38049e
> commit: 5f7099010eda61b777ba84cf9b64dc8428846d25 [10/11] i2c: viperboard: make use of the new infrastructure for quirks
> reproduce:
>   # apt-get install sparse
>   git checkout 5f7099010eda61b777ba84cf9b64dc8428846d25
>   make ARCH=x86_64 allmodconfig
>   make C=1 CF=-D__CHECK_ENDIAN__
> 
> 
> sparse warnings: (new ones prefixed by >>)
> 
>    drivers/i2c/busses/i2c-viperboard.c:128:35: sparse: incorrect type in assignment (different base types)
>    drivers/i2c/busses/i2c-viperboard.c:128:35:    expected unsigned short [unsigned] [usertype] addr
>    drivers/i2c/busses/i2c-viperboard.c:128:35:    got restricted __le16 [usertype] <noident>
>    drivers/i2c/busses/i2c-viperboard.c:201:34: sparse: incorrect type in assignment (different base types)
>    drivers/i2c/busses/i2c-viperboard.c:201:34:    expected unsigned short [unsigned] [usertype] tf1
>    drivers/i2c/busses/i2c-viperboard.c:201:34:    got restricted __le16 [usertype] <noident>
>    drivers/i2c/busses/i2c-viperboard.c:202:34: sparse: incorrect type in assignment (different base types)
>    drivers/i2c/busses/i2c-viperboard.c:202:34:    expected unsigned short [unsigned] [usertype] tf2
>    drivers/i2c/busses/i2c-viperboard.c:202:34:    got restricted __le16 [usertype] <noident>
>    drivers/i2c/busses/i2c-viperboard.c:237:35: sparse: incorrect type in assignment (different base types)
>    drivers/i2c/busses/i2c-viperboard.c:237:35:    expected unsigned short [unsigned] [usertype] addr
>    drivers/i2c/busses/i2c-viperboard.c:237:35:    got restricted __le16 [usertype] <noident>
>    drivers/i2c/busses/i2c-viperboard.c:300:35: sparse: incorrect type in assignment (different base types)
>    drivers/i2c/busses/i2c-viperboard.c:300:35:    expected unsigned short [unsigned] [usertype] len
>    drivers/i2c/busses/i2c-viperboard.c:300:35:    got restricted __le16 [usertype] <noident>
>    drivers/i2c/busses/i2c-viperboard.c:325:35: sparse: incorrect type in assignment (different base types)
>    drivers/i2c/busses/i2c-viperboard.c:325:35:    expected unsigned short [unsigned] [usertype] len
>    drivers/i2c/busses/i2c-viperboard.c:325:35:    got restricted __le16 [usertype] <noident>
> >> drivers/i2c/busses/i2c-viperboard.c:357:27: sparse: symbol 'vprbrd_quirks' was not declared. Should it be static?
> 
> Please review and possibly fold the followup patch.

Development branch noise, please ignore.


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

      parent reply	other threads:[~2015-01-08 18:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-08 18:07 [wsa:i2c/quirks 10/11] drivers/i2c/busses/i2c-viperboard.c:357:27: sparse: symbol 'vprbrd_quirks' was not declared. Should it be static? kbuild test robot
     [not found] ` <201501090239.gPJgrJIE%fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-01-08 18:07   ` [PATCH wsa] i2c: viperboard: vprbrd_quirks can be static kbuild test robot
2015-01-08 18:38 ` Wolfram Sang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150108183800.GC29629@katana \
    --to=wsa@the-dreams.de \
    --cc=fengguang.wu@intel.com \
    --cc=kbuild-all@01.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=poeschel@lemonage.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).