Re: [PATCH v2 2/4] i2c: designware-pci: shrink dw_pci_controllers array

[Mika Westerberg <mika.westerberg-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>]

On Fri, Jan 23, 2015 at 01:41:55PM +0100, Wolfram Sang wrote:
> On Fri, Jan 23, 2015 at 01:54:03PM +0200, Andy Shevchenko wrote:
> > There is no need to duplicate same data for each controller. If we need
> > specific stuff for a certain controller in the future we may add it later. The
> > patch leaves one controller per platform.
> > 
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
> > ---
> >  drivers/i2c/busses/i2c-designware-pcidrv.c | 63 ++++++------------------------
> >  1 file changed, 11 insertions(+), 52 deletions(-)
> > 
> > diff --git a/drivers/i2c/busses/i2c-designware-pcidrv.c b/drivers/i2c/busses/i2c-designware-pcidrv.c
> > index 5c6fca7..435a8ec 100644
> > --- a/drivers/i2c/busses/i2c-designware-pcidrv.c
> > +++ b/drivers/i2c/busses/i2c-designware-pcidrv.c
> > @@ -40,13 +40,7 @@
> >  #define DRIVER_NAME "i2c-designware-pci"
> >  
> >  enum dw_pci_ctl_id_t {
> > -	medfield_0,
> > -	medfield_1,
> > -	medfield_2,
> > -	medfield_3,
> > -	medfield_4,
> > -	medfield_5,
> > -
> > +	medfield,
> >  	baytrail,
> >  	haswell,
> >  };
> > @@ -98,47 +92,12 @@ static struct dw_scl_sda_cfg hsw_config = {
> >  };
> >  
> >  static struct  dw_pci_controller  dw_pci_controllers[] = {
> > -	[medfield_0] = {
> > -		.bus_num     = 0,
> 
> Wasn't that bus_num used to ensure stable bus numbers? Adding Mika.

That's right.

However, I don't think anybody really uses Medfield outside Intel so in
that sense this patch should not break anything.