From: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
To: Dmitry Torokhov
<dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] i2c: do not try to load modules for of-registered devices
Date: Mon, 26 Jan 2015 16:53:35 +0100 [thread overview]
Message-ID: <20150126155335.GA13494@katana> (raw)
In-Reply-To: <20150116080722.GA7813@dtor-ws>
[-- Attachment #1: Type: text/plain, Size: 724 bytes --]
On Fri, Jan 16, 2015 at 12:07:22AM -0800, Dmitry Torokhov wrote:
> Trying to register an I2C device asynchronously (via async_schedule() call)
> results in an ugly warning from request_module() warning about potential
> deadlock (because request_module tries to wait for async works to
> complete). While we could try to switch to request_module_nowait(), other
> buses, as well as I2C itself when not using device tree, do not try to load
> modules, but rather rely on the standard infrastructure (udev) to execute
> module loading, and we should be doing the same.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Sounds reasonable. Applied to for-next, thanks!
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2015-01-26 15:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-16 8:07 [PATCH] i2c: do not try to load modules for of-registered devices Dmitry Torokhov
2015-01-26 15:53 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150126155335.GA13494@katana \
--to=wsa-z923lk4zbo2bacvfa/9k2g@public.gmane.org \
--cc=dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).