From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfram Sang Subject: Re: [PATCH] i2c: do not try to load modules for of-registered devices Date: Mon, 26 Jan 2015 16:53:35 +0100 Message-ID: <20150126155335.GA13494@katana> References: <20150116080722.GA7813@dtor-ws> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="FCuugMFkClbJLl1L" Return-path: Content-Disposition: inline In-Reply-To: <20150116080722.GA7813@dtor-ws> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Dmitry Torokhov Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-i2c@vger.kernel.org --FCuugMFkClbJLl1L Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 16, 2015 at 12:07:22AM -0800, Dmitry Torokhov wrote: > Trying to register an I2C device asynchronously (via async_schedule() cal= l) > results in an ugly warning from request_module() warning about potential > deadlock (because request_module tries to wait for async works to > complete). While we could try to switch to request_module_nowait(), other > buses, as well as I2C itself when not using device tree, do not try to lo= ad > modules, but rather rely on the standard infrastructure (udev) to execute > module loading, and we should be doing the same. >=20 > Signed-off-by: Dmitry Torokhov Sounds reasonable. Applied to for-next, thanks! --FCuugMFkClbJLl1L Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJUxmL/AAoJEBQN5MwUoCm2Qz8P/0+iUOpc+ME4+Ea0LAsaC22Q 1iWpQiu1qFpVbNYBinXWuXSOwGD6YhjhlVmLVJ7F3cVL6ZV3ugEcWh9M6jG5IZL2 cFZVnEiIYMFwXZxVbqUhBHkWQOqFww0fVtwdSWUFL9WICxGzbeCgBDPp2Hqi1g/G xKqKHkEwVRCbEcIJMIHyhl+pnfSKiq0C/ikulXyKTaVO/8V7tTxJ1SWLhLxIxN43 t5DcFUV6ON+ALrv0Vtmb7Uv4fZxis/116QBylOYPbtUD4EBTo68UQmBEwI4IWJVc z1ejg6Y+NH5BTJHmDpDqaX9lzLny0J/LV2nOp0CL84mIBrpe8RXu2Oz/YSQWSiG5 rKy0ZLyY0S1fQlgUW7V1nZ2Xl8WjmE3hVWxTRLRlCDOikDE8e8fPWRUIBfHa68eb c//fSSeT3Asrgj0hmQC8OE+IA6hxk2dgBt1GoFcM0cpfTMSu3njsZu8nlymfIN/g UBUx0tb0tLrFJ/38tZeRyoNRjNXUtChcAf9K5C2sccWs8IzlDFA8on8qL07le/Wy rqexf3PUlxlF0ts3CQs9obubIZsWNues5hiB+yB2xln5TXpxtj7Z/VgnZdKQaueU Xood08tEKrZmcow3Ug0MHAEuIgXfBK0Wa79pxigNkftHOpB1PayxGcpNrY5z/OJh TbYb5wfj0MNO29EtLUW6 =IlbU -----END PGP SIGNATURE----- --FCuugMFkClbJLl1L--