From: Jean Delvare <jdelvare-l3A5Bk7waGM@public.gmane.org>
To: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
Cc: Linux I2C <linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH v2] i2c: Only include slave support if selected
Date: Mon, 26 Jan 2015 19:53:21 +0100 [thread overview]
Message-ID: <20150126195321.7f85e616@endymion.delvare> (raw)
In-Reply-To: <20150126180508.GB25317@katana>
On Mon, 26 Jan 2015 19:05:09 +0100, Wolfram Sang wrote:
> On Mon, Jan 26, 2015 at 07:00:47PM +0100, Jean Delvare wrote:
> > Make the slave support depend on CONFIG_I2C_SLAVE. Otherwise it gets
> > included unconditionally, even when it is not needed.
> >
> > Signed-off-by: Jean Delvare <jdelvare-l3A5Bk7waGM@public.gmane.org>
> > Cc: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
> > ---
> > Changes since v1:
> > * Let I2C_RCAR select I2C_SLAVE
> >
> > Wolfram, you mentioned i2c-sh_mobile but that driver doesn't seem to
> > implement slave support in v3.19-rc6 so I did not include it. Feel free
> > to add more selects to drivers/i2c/busses/Kconfig to match the current
> > state of your i2c tree.
>
> Sorry, my bad. I meant the RCAR driver which you spotted. What about the
> function pointers in the algo struct?
Doh, forgot about them once again. Stay tuned, patch v3 is coming...
--
Jean Delvare
SUSE L3 Support
prev parent reply other threads:[~2015-01-26 18:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-26 18:00 [PATCH v2] i2c: Only include slave support if selected Jean Delvare
[not found] ` <20150126190047.7bc44f26-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2015-01-26 18:05 ` Wolfram Sang
2015-01-26 18:53 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150126195321.7f85e616@endymion.delvare \
--to=jdelvare-l3a5bk7wagm@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).