linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
To: Danielle Costantino
	<danielle.costantino-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linux-i2c <linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] i2c/mpc: Fix ISR return value
Date: Thu, 5 Feb 2015 20:37:53 +0100	[thread overview]
Message-ID: <20150205193753.GH15307@katana> (raw)
In-Reply-To: <CAAVjN7fQ4RLgsk1R_DPrFm21OBWpsBdxMuDyQauiz3pxCgK+Lw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 975 bytes --]

On Fri, Jan 30, 2015 at 03:17:37AM -0800, Danielle Costantino wrote:
> I have been using the driver with this modification for the past 6
> months and it has been stable in an industrial environment.I had made
> a few other changes that also improve reliability (using ppc in_8 and
> out_8 and eieio barriers to ensure in-order execution. This lets you
> remove the unneeded double read of the status register. I also added a
> more robust recovery function to handle force of bus master-ship, and
> clearing the arb lost interrupt that is generated. currently this can
> cause the isr to trigger and cause superfluous interrupts. I have not
> posted this patch because of the extensive changes,
> 
> I will ack this patch.

Thanks for the detailed explanation. If you want to assist me even
further, please use the standard form for an Ack:

Acked-by: <your email>

Then patchwork will automatically collect the ack and I don't have to do
it manually.


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  parent reply	other threads:[~2015-02-05 19:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-30 10:24 [PATCH] i2c/mpc: Fix ISR return value Amit Tomar
2015-01-30 11:09 ` Danielle Costantino
     [not found] ` <BL2PR03MB449C87445D2FD1F15E9D33483310-AZ66ij2kwaaRkNCTDI+ukOO6mTEJWrR4XA4E9RH9d+qIuWR1G4zioA@public.gmane.org>
2015-01-30 11:17   ` Danielle Costantino
     [not found]     ` <CAAVjN7fQ4RLgsk1R_DPrFm21OBWpsBdxMuDyQauiz3pxCgK+Lw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-02-05 19:37       ` Wolfram Sang [this message]
2015-02-05 19:36   ` Wolfram Sang
2015-03-27 12:47     ` Amit Tomar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150205193753.GH15307@katana \
    --to=wsa-z923lk4zbo2bacvfa/9k2g@public.gmane.org \
    --cc=danielle.costantino-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).