From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Cohen Subject: Re: [PATCH v2 2/4] i2c: designware-pci: shrink dw_pci_controllers array Date: Thu, 5 Feb 2015 14:56:51 -0800 Message-ID: <20150205225651.GA1022@psi-dev26.jf.intel.com> References: <1422014045-20584-1-git-send-email-andriy.shevchenko@linux.intel.com> <1422014045-20584-2-git-send-email-andriy.shevchenko@linux.intel.com> <20150123124155.GA1906@katana> <20150123124805.GP1850@lahna.fi.intel.com> <1422018246.31903.162.camel@linux.intel.com> <20150124041914.GA1190@katana> <20150126121508.GE1052@katana> <20150205192136.GE15307@katana> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20150205192136.GE15307@katana> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Wolfram Sang Cc: Andy Shevchenko , Mika Westerberg , linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Jarkko Nikula List-Id: linux-i2c@vger.kernel.org On Thu, Feb 05, 2015 at 08:21:36PM +0100, Wolfram Sang wrote: > On Mon, Jan 26, 2015 at 01:15:08PM +0100, Wolfram Sang wrote: > > On Sat, Jan 24, 2015 at 05:19:14AM +0100, Wolfram Sang wrote: > > > On Fri, Jan 23, 2015 at 03:04:06PM +0200, Andy Shevchenko wrote: > > > > On Fri, 2015-01-23 at 14:48 +0200, Mika Westerberg wrote: > > > > > On Fri, Jan 23, 2015 at 01:41:55PM +0100, Wolfram Sang wrote: > > > > > > On Fri, Jan 23, 2015 at 01:54:03PM +0200, Andy Shevchenko wrote: > > > > > > > There is no need to duplicate same data for each controller. If we need > > > > > > > specific stuff for a certain controller in the future we may add it later. The > > > > > > > patch leaves one controller per platform. > > > > > > > > > > > > > > Signed-off-by: Andy Shevchenko > > > > > > > --- > > > > > > > drivers/i2c/busses/i2c-designware-pcidrv.c | 63 ++++++------------------------ > > > > > > > 1 file changed, 11 insertions(+), 52 deletions(-) > > > > > > > > > > > > > > diff --git a/drivers/i2c/busses/i2c-designware-pcidrv.c b/drivers/i2c/busses/i2c-designware-pcidrv.c > > > > > > > index 5c6fca7..435a8ec 100644 > > > > > > > --- a/drivers/i2c/busses/i2c-designware-pcidrv.c > > > > > > > +++ b/drivers/i2c/busses/i2c-designware-pcidrv.c > > > > > > > @@ -40,13 +40,7 @@ > > > > > > > #define DRIVER_NAME "i2c-designware-pci" > > > > > > > > > > > > > > enum dw_pci_ctl_id_t { > > > > > > > - medfield_0, > > > > > > > - medfield_1, > > > > > > > - medfield_2, > > > > > > > - medfield_3, > > > > > > > - medfield_4, > > > > > > > - medfield_5, > > > > > > > - > > > > > > > + medfield, > > > > > > > baytrail, > > > > > > > haswell, > > > > > > > }; > > > > > > > @@ -98,47 +92,12 @@ static struct dw_scl_sda_cfg hsw_config = { > > > > > > > }; > > > > > > > > > > > > > > static struct dw_pci_controller dw_pci_controllers[] = { > > > > > > > - [medfield_0] = { > > > > > > > - .bus_num = 0, > > > > > > > > > > > > Wasn't that bus_num used to ensure stable bus numbers? Adding Mika. > > > > > > > > > > That's right. > > > > > > > > > > However, I don't think anybody really uses Medfield outside Intel so in > > > > > that sense this patch should not break anything. > > > > > > > > I think better to ask David who is closer to that Intel MID area. > > > > > > OK, waiting for a reply from him here. > > > > @David: ping > > David: ping again Pong. Sorry for the delay. There are actually few products based on Medfield reference board and clovertrail+ as well uses medfield code. We need to keep the bus_num there for these SFI platforms. Br, David