From: Jean Delvare <jdelvare-l3A5Bk7waGM@public.gmane.org>
To: Jarkko Nikula <jarkko.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
Subject: Re: [PATCHv3 4/5] i2c: i801: Remove pci_enable_device() call from i801_resume()
Date: Mon, 16 Feb 2015 10:27:42 +0100 [thread overview]
Message-ID: <20150216102742.781bbaf2@endymion.delvare> (raw)
In-Reply-To: <1423835545-17991-4-git-send-email-jarkko.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
On Fri, 13 Feb 2015 15:52:24 +0200, Jarkko Nikula wrote:
> Since pci_disable_device() is not called from i801_suspend() and power
> state is set already it means that subsequent pci_enable_device() calls do
> practically nothing but monotonically increase struct pci_dev enable_cnt.
>
> Signed-off-by: Jarkko Nikula <jarkko.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
> ---
> drivers/i2c/busses/i2c-i801.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c
> index b1d725d758bb..5fb35464f693 100644
> --- a/drivers/i2c/busses/i2c-i801.c
> +++ b/drivers/i2c/busses/i2c-i801.c
> @@ -1324,7 +1324,7 @@ static int i801_resume(struct pci_dev *dev)
> {
> pci_set_power_state(dev, PCI_D0);
> pci_restore_state(dev);
> - return pci_enable_device(dev);
> + return 0;
> }
> #else
> #define i801_suspend NULL
Reviewed-by: Jean Delvare <jdelvare-l3A5Bk7waGM@public.gmane.org>
--
Jean Delvare
SUSE L3 Support
next prev parent reply other threads:[~2015-02-16 9:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-13 13:52 [PATCHv3 1/5] i2c: i801: Don't break user-visible strings Jarkko Nikula
[not found] ` <1423835545-17991-1-git-send-email-jarkko.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2015-02-13 13:52 ` [PATCHv3 2/5] i2c: i801: Remove i801_driver forward declaration Jarkko Nikula
2015-02-13 13:52 ` [PATCHv3 3/5] i2c: i801: Use managed devm_* memory and irq allocation Jarkko Nikula
2015-02-13 13:52 ` [PATCHv3 4/5] i2c: i801: Remove pci_enable_device() call from i801_resume() Jarkko Nikula
[not found] ` <1423835545-17991-4-git-send-email-jarkko.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2015-02-16 9:27 ` Jean Delvare [this message]
2015-02-13 13:52 ` [PATCHv3 5/5] i2c: i801: Use managed pcim_* PCI device initialization and reservation Jarkko Nikula
[not found] ` <1423835545-17991-5-git-send-email-jarkko.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2015-02-16 9:29 ` Jean Delvare
[not found] ` <20150216102918.53042ba0-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2015-03-06 23:51 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150216102742.781bbaf2@endymion.delvare \
--to=jdelvare-l3a5bk7wagm@public.gmane.org \
--cc=jarkko.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).