Re: linux-next: Tree for Feb 17 (i2c-designware-baytrail.c)

Re: linux-next: Tree for Feb 17 (i2c-designware-baytrail.c)

[Randy Dunlap]

On 02/16/15 21:02, Stephen Rothwell wrote:
> Hi all,
> 
> Please do not add any material destined for v3.21 to your linux-next
> included trees until after v3.20-rc1 has been released.
> 
> Changes since 20150216:
> 

on i386, when CONFIG_IOSF_MBI=m and
CONFIG_I2C_DESIGNWARE_BAYTRAIL=y:

drivers/built-in.o: In function `i2c_dw_eval_lock_support':
(.text+0x37dd74): undefined reference to `iosf_mbi_available'
drivers/built-in.o: In function `reset_semaphore.isra.1':
i2c-designware-baytrail.c:(.text+0x37ddd1): undefined reference to `iosf_mbi_read'
i2c-designware-baytrail.c:(.text+0x37de13): undefined reference to `iosf_mbi_write'
drivers/built-in.o: In function `baytrail_i2c_acquire':
(.text+0x37df26): undefined reference to `iosf_mbi_write'
drivers/built-in.o: In function `baytrail_i2c_acquire':
(.text+0x37dfab): undefined reference to `iosf_mbi_read'
drivers/built-in.o: In function `baytrail_i2c_acquire':
(.text+0x37e080): undefined reference to `iosf_mbi_read'


because IOSF_MBI is tristate and I2C_DESIGNWARE_BAYTRAIL is bool:

config I2C_DESIGNWARE_BAYTRAIL
	bool "Intel Baytrail I2C semaphore support"
	depends on I2C_DESIGNWARE_PLATFORM && IOSF_MBI && ACPI


I suppose someone could make that:

	depends on I2C_DESIGNWARE_PLATFORM && IOSF_MBI=y && ACPI

or even make I2C_DESIGNWARE_BAYTRAIL be a tristate symbol.


-- 
~Randy

Re: linux-next: Tree for Feb 17 (i2c-designware-baytrail.c)

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 376 bytes --]

Randy,

thanks for the report!

> I suppose someone could make that:
> 
> 	depends on I2C_DESIGNWARE_PLATFORM && IOSF_MBI=y && ACPI
> 
> or even make I2C_DESIGNWARE_BAYTRAIL be a tristate symbol.

I'll wait a day for input from David what he prefers, because I don't
own/know this platform. If there is no response, I'll apply the first
solution.

   Wolfram


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: linux-next: Tree for Feb 17 (i2c-designware-baytrail.c)

[David E. Box]

Hi Wolfram,

On Tue, Feb 17, 2015 at 08:11:58PM +0100, Wolfram Sang wrote:
> Randy,
> 
> thanks for the report!
> 
> > I suppose someone could make that:
> > 
> > 	depends on I2C_DESIGNWARE_PLATFORM && IOSF_MBI=y && ACPI
> > 
> > or even make I2C_DESIGNWARE_BAYTRAIL be a tristate symbol.
> 
> I'll wait a day for input from David what he prefers, because I don't
> own/know this platform. If there is no response, I'll apply the first
> solution.
> 

This is fine with me. I own IOSF_MBI as well. Thanks.

Dave