From: Wolfram Sang <wsa@the-dreams.de>
To: christian.ruppert@alitech.com
Cc: Alexey Brodkin <Alexey.Brodkin@synopsys.com>,
"andriy.shevchenko@linux.intel.com"
<andriy.shevchenko@linux.intel.com>,
"christian.ruppert@abilis.com" <christian.ruppert@abilis.com>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"mika.westerberg@linux.intel.com"
<mika.westerberg@linux.intel.com>,
"Vineet.Gupta1@synopsys.com" <Vineet.Gupta1@synopsys.com>
Subject: Re: [PATCH] i2c: designware: Suppress error message if platform_get_irq() returns -EPROBE_DEFER
Date: Tue, 3 Mar 2015 18:21:45 +0100 [thread overview]
Message-ID: <20150303172145.GA7076@katana> (raw)
In-Reply-To: <OF441D1D4D.39476C28-ONC1257DFD.005BE73C-C1257DFD.005C7908@alitech.com>
[-- Attachment #1: Type: text/plain, Size: 454 bytes --]
> which omit this type of messages completely. Andy's proposal of
> centralising this looks like a very good solution here (and on top of
> that removes many useless strings from the kernel binary).
I am all for centralizing printouts. I recommended this at my ELCE talk
last year, too. However, you need to keep in mind that irqs are
sometimes optional and you don't want error messages for those irqs.
IMO worthwhile, but not a low hanging fruit...
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-03-03 17:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-03 15:27 [PATCH] i2c: designware: Suppress error message if platform_get_irq() returns -EPROBE_DEFER Alexey Brodkin
2015-03-03 16:28 ` Christian Ruppert
[not found] ` <54F5E120.3090705-Yycd8EPnGM5BDgjK7y7TUQ@public.gmane.org>
2015-03-03 16:37 ` Alexey Brodkin
[not found] ` <1425400650.17965.53.camel-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>
2015-03-03 16:50 ` christian.ruppert-Yycd8EPnGM5BDgjK7y7TUQ
2015-03-03 17:21 ` Wolfram Sang [this message]
2015-03-03 17:46 ` Christian Ruppert
2015-03-03 19:03 ` Andy Shevchenko
[not found] ` <1425409412.14897.157.camel-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2015-03-03 19:11 ` Wolfram Sang
2015-03-03 19:34 ` Andy Shevchenko
2015-03-07 0:24 ` Wolfram Sang
2015-03-09 8:29 ` Alexey Brodkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150303172145.GA7076@katana \
--to=wsa@the-dreams.de \
--cc=Alexey.Brodkin@synopsys.com \
--cc=Vineet.Gupta1@synopsys.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=christian.ruppert@abilis.com \
--cc=christian.ruppert@alitech.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).