linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jean Delvare <jdelvare-l3A5Bk7waGM@public.gmane.org>
To: Angelo Compagnucci
	<angelo.compagnucci-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: i2c-tools: add Android.mk
Date: Mon, 16 Mar 2015 10:16:26 +0100	[thread overview]
Message-ID: <20150316101626.2c7a02be@endymion.delvare> (raw)
In-Reply-To: <CA+TH9VkQzJaSa0okxK+s1ukpaqgiWegh3uumEb63LzZwBjV4nA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

Hi Angelo,

On Fri, 27 Feb 2015 22:05:12 +0100, Angelo Compagnucci wrote:
> This patch adds an Android.mk to compile i2c-tools under Android.
> 
> Hope this helps!

I have to say I don't know what to do with this.

For one thing, I don't really understand why Android needs a separate
build mechanism when all other Linux and BSD incarnations seem to be
fine with the standard Makefile. GNU make certainly runs on Android,
right? And you would typically cross-compile for Android anyway. Also I
have not seen an Android.mk file in any other project I'm working on,
and I can't see why i2c-tools would be special in this respect.

For another, the current build mechanism is a modular one where the
main Makefile includes Module.mk files present in the different
subdirectories. I like this design and having a single Android.mk file
at the root of the project is inconsistent and breaks that design.

As a summary I don't see why anything special is needed for Android,
but if something like that is really needed then it should respect the
existing modular design.

Now if anyone has a more educated view on this than I do, please speak
up. Android is really not my thing (as a developer, I mean.)

Thanks,
-- 
Jean Delvare
SUSE L3 Support

  parent reply	other threads:[~2015-03-16  9:16 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-27 21:05 i2c-tools: add Android.mk Angelo Compagnucci
     [not found] ` <CA+TH9VkQzJaSa0okxK+s1ukpaqgiWegh3uumEb63LzZwBjV4nA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-03-16  9:16   ` Jean Delvare [this message]
     [not found]     ` <20150316101626.2c7a02be-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2015-03-16  9:30       ` Angelo Compagnucci
2015-06-17 10:29       ` Wolfram Sang
2015-06-17 10:38         ` Angelo Compagnucci
     [not found]           ` <CA+TH9Vm7oKH43S7j5G2_iQi7cF=y3G04V_nrswQ+6E1J6JNbOg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-06-17 10:46             ` Wolfram Sang
2015-06-17 12:13             ` Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150316101626.2c7a02be@endymion.delvare \
    --to=jdelvare-l3a5bk7wagm@public.gmane.org \
    --cc=angelo.compagnucci-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).