From: "Jakub Kiciński" <moorray3-5tc4TXWwyLM@public.gmane.org>
To: Jon Ringle <jon-7zJyie9iPacdnm+yROfE0A@public.gmane.org>
Cc: "Greg Kroah-Hartman"
<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
"Ringle,
Jonathan"
<Jonathan.Ringle-gkqdKIIuv0Hby3iVrkZq2A@public.gmane.org>,
"linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"Karol Dębogórski" <k.debogorski-XA5MxPtj9CQ@public.gmane.org>,
"Jakub Kicinski" <kubakici-5tc4TXWwyLM@public.gmane.org>
Subject: Re: [PATCH 3/4] sc16is7xx: expose RTS inversion in RS-485 mode
Date: Tue, 17 Mar 2015 15:57:00 +0100 [thread overview]
Message-ID: <20150317155700.71a4ad1b@north> (raw)
In-Reply-To: <alpine.DEB.2.10.1503171043400.3566-cn3jTo8IYkmeSY0hgfj7bYJKnSiCLr9B28t4la5Gatg@public.gmane.org>
On Tue, 17 Mar 2015 10:45:26 -0400 (EDT), Jon Ringle wrote:
> This makes sense. I did have to fix up my user space app to set
> SER_RS485_RTS_ON_SEND after applying this patch.
Yes, perhaps I should have mentioned that this makes the ioctl return
-EINVAL when neither of SER_RS485_RTS_*_SEND flags is set. This
definitely has potential to break people's apps. Let's see if anyone
else has an opinion on this.
I am also very tempted to remove rs485.delay_rts_*_send mdelays from
this driver and return -EINVAL in a similar fashion when there are set.
Normally when the driver is responsible for wiggling the GPIO/RTS line
mdelays can indeed impact when the lines change state but in sc16is7xx
case transitions are controlled by HW and there is nothing the driver
can do about the the relation between TX/RX mode switch and state of
RTS lines... Do you agree?
next prev parent reply other threads:[~2015-03-17 14:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-16 23:28 [PATCH 0/4] serial: sc16is7xx: bunch of small fixes Jakub Kicinski
[not found] ` <1426548529-21738-1-git-send-email-moorray3-5tc4TXWwyLM@public.gmane.org>
2015-03-16 23:28 ` [PATCH 1/4] sc16is7xx: remove ports on probe error path Jakub Kicinski
[not found] ` <1426548529-21738-2-git-send-email-moorray3-5tc4TXWwyLM@public.gmane.org>
2015-03-17 14:41 ` Jon Ringle
2015-03-16 23:28 ` [PATCH 2/4] sc16is7xx: don't wipe out port configuration on shutdown Jakub Kicinski
[not found] ` <1426548529-21738-3-git-send-email-moorray3-5tc4TXWwyLM@public.gmane.org>
2015-03-17 14:43 ` Jon Ringle
2015-03-16 23:28 ` [PATCH 3/4] sc16is7xx: expose RTS inversion in RS-485 mode Jakub Kicinski
[not found] ` <1426548529-21738-4-git-send-email-moorray3-5tc4TXWwyLM@public.gmane.org>
2015-03-17 14:45 ` Jon Ringle
[not found] ` <alpine.DEB.2.10.1503171043400.3566-cn3jTo8IYkmeSY0hgfj7bYJKnSiCLr9B28t4la5Gatg@public.gmane.org>
2015-03-17 14:57 ` Jakub Kiciński [this message]
2015-03-26 21:37 ` Greg Kroah-Hartman
[not found] ` <20150326213701.GA29278-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2015-03-26 21:48 ` Jakub Kiciński
2015-03-16 23:28 ` [PATCH 4/4] sc16is7xx: enable the clock Jakub Kicinski
[not found] ` <1426548529-21738-5-git-send-email-moorray3-5tc4TXWwyLM@public.gmane.org>
2015-03-17 14:46 ` Jon Ringle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150317155700.71a4ad1b@north \
--to=moorray3-5tc4txwwylm@public.gmane.org \
--cc=Jonathan.Ringle-gkqdKIIuv0Hby3iVrkZq2A@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=jon-7zJyie9iPacdnm+yROfE0A@public.gmane.org \
--cc=k.debogorski-XA5MxPtj9CQ@public.gmane.org \
--cc=kubakici-5tc4TXWwyLM@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).