From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Subject: Re: [PATCH 3/4] sc16is7xx: expose RTS inversion in RS-485 mode Date: Thu, 26 Mar 2015 22:37:01 +0100 Message-ID: <20150326213701.GA29278@kroah.com> References: <1426548529-21738-1-git-send-email-moorray3@wp.pl> <1426548529-21738-4-git-send-email-moorray3@wp.pl> <20150317155700.71a4ad1b@north> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <20150317155700.71a4ad1b@north> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jakub =?utf-8?B?S2ljacWEc2tp?= Cc: Jon Ringle , "Ringle, Jonathan" , "linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Karol =?utf-8?B?RMSZYm9nw7Nyc2tp?= , Jakub Kicinski List-Id: linux-i2c@vger.kernel.org On Tue, Mar 17, 2015 at 03:57:00PM +0100, Jakub Kici=C5=84ski wrote: > On Tue, 17 Mar 2015 10:45:26 -0400 (EDT), Jon Ringle wrote: > > This makes sense. I did have to fix up my user space app to set=20 > > SER_RS485_RTS_ON_SEND after applying this patch. >=20 > Yes, perhaps I should have mentioned that this makes the ioctl return > -EINVAL when neither of SER_RS485_RTS_*_SEND flags is set. This > definitely has potential to break people's apps. Let's see if anyone > else has an opinion on this. Yes, don't break people's apps. I can't take this, sorry. greg k-h