From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub =?UTF-8?B?S2ljacWEc2tp?= Subject: Re: [PATCH 3/4] sc16is7xx: expose RTS inversion in RS-485 mode Date: Thu, 26 Mar 2015 22:48:27 +0100 Message-ID: <20150326224827.198f09ec@north> References: <1426548529-21738-1-git-send-email-moorray3@wp.pl> <1426548529-21738-4-git-send-email-moorray3@wp.pl> <20150317155700.71a4ad1b@north> <20150326213701.GA29278@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20150326213701.GA29278-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Greg Kroah-Hartman Cc: Jon Ringle , "Ringle, Jonathan" , "linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Karol =?UTF-8?B?RMSZYm9nw7Nyc2tp?= , Jakub Kicinski List-Id: linux-i2c@vger.kernel.org On Thu, 26 Mar 2015 22:37:01 +0100, Greg Kroah-Hartman wrote: > On Tue, Mar 17, 2015 at 03:57:00PM +0100, Jakub Kici=C5=84ski wrote: > > On Tue, 17 Mar 2015 10:45:26 -0400 (EDT), Jon Ringle wrote: > > > This makes sense. I did have to fix up my user space app to set=20 > > > SER_RS485_RTS_ON_SEND after applying this patch. > >=20 > > Yes, perhaps I should have mentioned that this makes the ioctl retu= rn > > -EINVAL when neither of SER_RS485_RTS_*_SEND flags is set. This > > definitely has potential to break people's apps. Let's see if anyo= ne > > else has an opinion on this. >=20 > Yes, don't break people's apps. Do you mean it would be OK if I ignore the incorrect combinations instead of returning -EINVAL or is any user-visible change in the behaviour of the driver unacceptable?