From: Wolfram Sang <wsa@the-dreams.de>
To: Nicholas Mc Guire <hofrat@osadl.org>
Cc: Sekhar Nori <nsekhar@ti.com>,
Kevin Hilman <khilman@deeprootsystems.com>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: davinci: fixup wait_for_completion_timeout handling
Date: Fri, 27 Mar 2015 16:50:34 +0100 [thread overview]
Message-ID: <20150327155034.GF27238@katana> (raw)
In-Reply-To: <1426578673-10692-1-git-send-email-hofrat@osadl.org>
[-- Attachment #1: Type: text/plain, Size: 593 bytes --]
On Tue, Mar 17, 2015 at 03:51:13AM -0400, Nicholas Mc Guire wrote:
> wait_for_completion_timeout return 0 (timeout) or >=1 (completion) so the check
> for >= 0 is always true and can be dropped implying that r==-EREMOTEIO and thus
> the return of -EREMOTEIO can be done in the if (dev->buf_len) branch.
> As wait_for_completion_timeout returns unsigned long not int, and int r is
> exclusively used for wait_for_completion_timeout it is renamed and the type
> changed to unsigned long.
>
> Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
Applied to for-next, thanks!
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2015-03-27 15:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-17 7:51 [PATCH] i2c: davinci: fixup wait_for_completion_timeout handling Nicholas Mc Guire
2015-03-17 9:29 ` Alexander Sverdlin
2015-03-27 15:50 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150327155034.GF27238@katana \
--to=wsa@the-dreams.de \
--cc=hofrat@osadl.org \
--cc=khilman@deeprootsystems.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nsekhar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).