linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
To: Alexander Sverdlin
	<alexander.sverdlin-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
Cc: "ext Grygorii.Strashko-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org"
	<grygorii.strashko-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 0/3] i2c: davinci: Fix problems discovered on Keystone CPU
Date: Fri, 3 Apr 2015 22:14:39 +0200	[thread overview]
Message-ID: <20150403201439.GF2016@katana> (raw)
In-Reply-To: <550145C7.20503-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 1529 bytes --]

On Thu, Mar 12, 2015 at 08:52:39AM +0100, Alexander Sverdlin wrote:
> Hi!
> 
> On 11/03/15 19:35, ext Grygorii.Strashko-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org wrote:
> >> The series address the follwing problems:
> >> > "i2c: davinci: Rework racy ISR" -- stop the parallel activities in the driver
> >> > including concurrect registers access. Also simplifies the design and removes
> >> > some bad aids.
> >> > "i2c: davinci: Refactor i2c_davinci_wait_bus_not_busy()" -- the routine is
> >> > over-designed and instead of "waiting" will trigger the bus recovering
> >> > immediately.
> >> > "i2c: davinci: Avoid sending to own address" -- works around one davinci
> >> > controller issue when it unexpectedly switches to some sort of slave mode
> >> > trying to send to its own address. The controller remains in this locked state
> >> > until reset, so it's better to avoid this situation than to deal with transfer
> >> > timeouts.
> >> > 
> > 
> > Have you used git format-patch --cover-letter?
> > Overall stats and list of patches are missing.
> 
> Will do in v2...

And please make sure the patches are chained to the cover-letter. That
makes reviewing much easier.

> First patch is an important fix for blocking problem and therefore a candidate for
> -stable backports. So, it should be less dependent of the less-important 2 and 3.

IMO this patch is too intrusive for stable, so I won't add the tag. You
may request that individually to stable maintainers, though, if you
disagree.


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

      parent reply	other threads:[~2015-04-03 20:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-11 13:08 [PATCH 0/3] i2c: davinci: Fix problems discovered on Keystone CPU Alexander Sverdlin
     [not found] ` <55003E60.3070306-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
2015-03-11 18:35   ` Grygorii.Strashko-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org
     [not found]     ` <55008AF1.80405-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-03-12  7:52       ` Alexander Sverdlin
     [not found]         ` <550145C7.20503-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
2015-04-03 20:14           ` Wolfram Sang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150403201439.GF2016@katana \
    --to=wsa-z923lk4zbo2bacvfa/9k2g@public.gmane.org \
    --cc=alexander.sverdlin-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org \
    --cc=grygorii.strashko-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).