From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean Delvare Subject: Re: [RFC] i2c-tools: i2ctransfer: add new tool Date: Tue, 21 Apr 2015 07:25:51 +0200 Message-ID: <20150421072551.326bb4b7@endymion.delvare> References: <1425053816-19804-1-git-send-email-wsa@the-dreams.de> <20150420173638.GA1452@katana> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150420173638.GA1452@katana> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Wolfram Sang Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Magnus Damm , Simon Horman , Laurent Pinchart , Geert Uytterhoeven , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-i2c@vger.kernel.org Hi Wolfram, On Mon, 20 Apr 2015 19:36:38 +0200, Wolfram Sang wrote: > On Fri, Feb 27, 2015 at 05:16:56PM +0100, Wolfram Sang wrote: > > This tool allows to construct and concat multiple I2C messages into one > > single transfer. Its aim is to test I2C master controllers, and so there > > is no SMBus fallback. > > > > Signed-off-by: Wolfram Sang > > --- > > > > I've been missing such a tool a number of times now, so I finally got around to > > writing it myself. As with all I2C tools, it can be dangerous, but it can also > > be very useful when developing. I am not sure if distros should supply it, I'll > > leave that to Jean's experience. For embedded build systems, I think this > > should be selectable. It is RFC for now because it needs broader testing and some > > more beautification. However, I've been using it already to test the i2c_quirk > > infrastructure and Renesas I2C controllers. > > Jean, my tests went well and so I want to brush it up for inclusion into > i2c-tools upstream. Any show-stoppers you see from a high-level point of > view? I think it is a good idea, just I couldn't find the time to review it, sorry :( -- Jean Delvare SUSE L3 Support