From: Wolfram Sang <wsa@the-dreams.de>
To: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Cc: kgene@kernel.org, linux-samsung-soc@vger.kernel.org,
linux-i2c@vger.kernel.org, lars@metafoo.de
Subject: Re: [PATCH v2] i2c: Mark adapter devices with pm_runtime_no_callbacks
Date: Wed, 22 Apr 2015 09:54:06 +0200 [thread overview]
Message-ID: <20150422075406.GE1511@katana> (raw)
In-Reply-To: <1429185919-26098-1-git-send-email-ckeepax@opensource.wolfsonmicro.com>
[-- Attachment #1: Type: text/plain, Size: 925 bytes --]
On Thu, Apr 16, 2015 at 01:05:19PM +0100, Charles Keepax wrote:
> Commit 523c5b89640e ("i2c: Remove support for legacy PM") removed the PM
> ops from the bus type, which causes the pm operations on the s3c2410
> adapter device to fail (-ENOSUPP in rpm_callback). The adapter device
> doesn't get bound to a driver and as such can't have its own pm_runtime
> callbacks. Previously this was fine as the bus callbacks would have been
> used, but now this can cause devices which use PM runtime and are
> attached over I2C to fail to resume.
>
> This commit fixes this issue by marking all adapter devices with
> pm_runtime_no_callbacks, since they can't have any.
>
> Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Applied to for-current, thanks!
Will push out somewhat later today. Lars-Peter, if you'd like to donate
some ack/review tag until then, this would be much appreciated.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2015-04-22 7:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-16 12:05 [PATCH v2] i2c: Mark adapter devices with pm_runtime_no_callbacks Charles Keepax
2015-04-16 12:28 ` Beata Michalska
2015-04-22 7:55 ` Wolfram Sang
2015-04-22 7:54 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150422075406.GE1511@katana \
--to=wsa@the-dreams.de \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=kgene@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox