From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: Why isn't IRQ shared for i2c-ocore Date: Fri, 8 May 2015 07:57:47 +0100 Message-ID: <20150508065747.GG16220@x1> References: <55304D8E.8070204@freescale.com> <55312AF7.7070504@freescale.com> <20150420064231.GE3447@x1> <55352839.70905@freescale.com> <20150420181651.GF3447@x1> <5535460B.2060309@freescale.com> <20150421073534.GK3447@x1> <554A8A8B.1020703@freescale.com> <20150507070149.GB3400@x1> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Geert Uytterhoeven Cc: York Sun , Julia Lawall , Linux I2C , wolfram-z923LK4zBo2bacvFa/9K2g@public.gmane.org, "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-i2c@vger.kernel.org On Fri, 08 May 2015, Geert Uytterhoeven wrote: > On Thu, May 7, 2015 at 9:01 AM, Lee Jones wrot= e: > >> I have a follow up question regarding interrupt. I see many I2C bu= s drivers > >> request interrupt with flag =3D 0. Why not using IRQF_SHARED? > > > > Probably because that particular IRQ is only used by the I2C > > Controller. I'm not exactly sure that you're getting at? Why do y= ou > > think it should be shared? You should only flag it as shared if it > > is. >=20 > However, that's something the driver can't know. > Sharing interrupts is an integration property. The same IP core may s= hare its > interrupt on one SoC, and not on another. I guess that would depend on the IP. If this is part of an MFD, you'd know if you only hand a single interrupt line coming into the chip or not. If the IP can be moved around (copy & pasted) into different chips, then yes, that might change. How does one share an interrupt with other drivers if all them don't know the IRQ is shared thought? --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog