From mboxrd@z Thu Jan 1 00:00:00 1970 From: wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org Subject: Re: [PATCH] i2c: powermac: don't workaround for keywest Date: Mon, 11 May 2015 09:34:28 +0200 Message-ID: <20150511073428.GA3110@schokonusskuchen.bad> References: <1431192213-2904-1-git-send-email-wsa@the-dreams.de> <20150510183431.GA1510@katana> <1431296087.13039.13.camel@kernel.crashing.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8BIT Return-path: Content-Disposition: inline In-Reply-To: <1431296087.13039.13.camel-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Benjamin Herrenschmidt Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Dan DeVoto , Mark Elliott List-Id: linux-i2c@vger.kernel.org On Mon, May 11, 2015 at 08:14:47AM +1000, Benjamin Herrenschmidt wrote: > On Sun, 2015-05-10 at 20:34 +0200, Wolfram Sang wrote: > > Okay, so this patch is bogus. I understand now that onyx uses another > > codec than TAS, so this change will regress on other machines. > > However, > > it shows that this unconditional instantiation of the TAS breaks sound > > on Macintoshs which still need non-aoa sound support. I assume there > > will be noone in the near future to convert Keywest to AOA, so we'll > > need to find a hackish way around this instantiation problem. > > Converting the old macs that use TAS shouldn't be *that* hard, main > problem is I don't have the hardware to test... Dan and Mark (on CC) have been very helpful with testing. Maybe they are also in to test "the proper solution"?