Re: [PATCH 1/2] i2c: core: Remove needless structure member zero initialization

[Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1649 bytes --]

On Wed, Apr 29, 2015 at 03:44:36PM +0300, Jarkko Nikula wrote:
> No need to clear one struct i2c_client member variable since memset has
> already cleared all of them. Remove also one space intendation from err
> label.

Ehrm, why change this now when you remove the code block in the next
patch anyhow? :)

Also, the indentation thing is very likely intentional. Sadly, I can't
remember why at this moment, but I remember that when I tried to grep
something I understood why some people put a space in front of labels

> 
> Signed-off-by: Jarkko Nikula <jarkko.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
> ---
>  drivers/i2c/i2c-core.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c
> index 987c124432c5..051aa3a811a8 100644
> --- a/drivers/i2c/i2c-core.c
> +++ b/drivers/i2c/i2c-core.c
> @@ -283,7 +283,6 @@ acpi_i2c_space_handler(u32 function, acpi_physical_address command,
>  	memset(&client, 0, sizeof(client));
>  	client.adapter = adapter;
>  	client.addr = sb->slave_address;
> -	client.flags = 0;
>  
>  	if (sb->access_mode == ACPI_I2C_10BIT_MODE)
>  		client.flags |= I2C_CLIENT_TEN;
> @@ -361,7 +360,7 @@ acpi_i2c_space_handler(u32 function, acpi_physical_address command,
>  
>  	gsb->status = status;
>  
> - err:
> +err:
>  	ACPI_FREE(ares);
>  	return ret;
>  }
> -- 
> 2.1.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]