From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Horman Subject: Re: [PATCH] i2c: check for proper length of the reg property Date: Wed, 20 May 2015 11:20:11 +0900 Message-ID: <20150520022011.GC31103@verge.net.au> References: <1432052988-6187-1-git-send-email-wsa@the-dreams.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1432052988-6187-1-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Wolfram Sang Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Magnus Damm , Laurent Pinchart , Geert Uytterhoeven List-Id: linux-i2c@vger.kernel.org On Tue, May 19, 2015 at 06:29:48PM +0200, Wolfram Sang wrote: > From: Wolfram Sang > > int is vague, let's simply use the type of the variable in question. > > Signed-off-by: Wolfram Sang Reviewed-by: Simon Horman > --- > drivers/i2c/i2c-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c > index 987c124432c501..c517fc9d222c8f 100644 > --- a/drivers/i2c/i2c-core.c > +++ b/drivers/i2c/i2c-core.c > @@ -1272,7 +1272,7 @@ static struct i2c_client *of_i2c_register_device(struct i2c_adapter *adap, > } > > addr = of_get_property(node, "reg", &len); > - if (!addr || (len < sizeof(int))) { > + if (!addr || (len < sizeof(*addr))) { > dev_err(&adap->dev, "of_i2c: invalid reg on %s\n", > node->full_name); > return ERR_PTR(-EINVAL); > -- > 2.1.4 >