* [PATCH] i2c: check for proper length of the reg property
@ 2015-05-19 16:29 Wolfram Sang
[not found] ` <1432052988-6187-1-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Wolfram Sang @ 2015-05-19 16:29 UTC (permalink / raw)
To: linux-i2c-u79uwXL29TY76Z2rM5mHXA
Cc: linux-sh-u79uwXL29TY76Z2rM5mHXA, Magnus Damm, Simon Horman,
Laurent Pinchart, Geert Uytterhoeven, Wolfram Sang
From: Wolfram Sang <wsa+renesas-jBu1N2QxHDJrcw3mvpCnnVaTQe2KTcn/@public.gmane.org>
int is vague, let's simply use the type of the variable in question.
Signed-off-by: Wolfram Sang <wsa+renesas-jBu1N2QxHDJrcw3mvpCnnVaTQe2KTcn/@public.gmane.org>
---
drivers/i2c/i2c-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c
index 987c124432c501..c517fc9d222c8f 100644
--- a/drivers/i2c/i2c-core.c
+++ b/drivers/i2c/i2c-core.c
@@ -1272,7 +1272,7 @@ static struct i2c_client *of_i2c_register_device(struct i2c_adapter *adap,
}
addr = of_get_property(node, "reg", &len);
- if (!addr || (len < sizeof(int))) {
+ if (!addr || (len < sizeof(*addr))) {
dev_err(&adap->dev, "of_i2c: invalid reg on %s\n",
node->full_name);
return ERR_PTR(-EINVAL);
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread[parent not found: <1432052988-6187-1-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>]
* Re: [PATCH] i2c: check for proper length of the reg property [not found] ` <1432052988-6187-1-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org> @ 2015-05-20 2:20 ` Simon Horman 2015-05-31 23:30 ` Wolfram Sang 1 sibling, 0 replies; 3+ messages in thread From: Simon Horman @ 2015-05-20 2:20 UTC (permalink / raw) To: Wolfram Sang Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA, linux-sh-u79uwXL29TY76Z2rM5mHXA, Magnus Damm, Laurent Pinchart, Geert Uytterhoeven On Tue, May 19, 2015 at 06:29:48PM +0200, Wolfram Sang wrote: > From: Wolfram Sang <wsa+renesas-jBu1N2QxHDJrcw3mvpCnnVaTQe2KTcn/@public.gmane.org> > > int is vague, let's simply use the type of the variable in question. > > Signed-off-by: Wolfram Sang <wsa+renesas-jBu1N2QxHDJrcw3mvpCnnVaTQe2KTcn/@public.gmane.org> Reviewed-by: Simon Horman <horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org> > --- > drivers/i2c/i2c-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c > index 987c124432c501..c517fc9d222c8f 100644 > --- a/drivers/i2c/i2c-core.c > +++ b/drivers/i2c/i2c-core.c > @@ -1272,7 +1272,7 @@ static struct i2c_client *of_i2c_register_device(struct i2c_adapter *adap, > } > > addr = of_get_property(node, "reg", &len); > - if (!addr || (len < sizeof(int))) { > + if (!addr || (len < sizeof(*addr))) { > dev_err(&adap->dev, "of_i2c: invalid reg on %s\n", > node->full_name); > return ERR_PTR(-EINVAL); > -- > 2.1.4 > ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] i2c: check for proper length of the reg property [not found] ` <1432052988-6187-1-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org> 2015-05-20 2:20 ` Simon Horman @ 2015-05-31 23:30 ` Wolfram Sang 1 sibling, 0 replies; 3+ messages in thread From: Wolfram Sang @ 2015-05-31 23:30 UTC (permalink / raw) To: linux-i2c-u79uwXL29TY76Z2rM5mHXA Cc: linux-sh-u79uwXL29TY76Z2rM5mHXA, Magnus Damm, Simon Horman, Laurent Pinchart, Geert Uytterhoeven On Tue, May 19, 2015 at 06:29:48PM +0200, Wolfram Sang wrote: > From: Wolfram Sang <wsa+renesas-jBu1N2QxHDJrcw3mvpCnnVaTQe2KTcn/@public.gmane.org> > > int is vague, let's simply use the type of the variable in question. > > Signed-off-by: Wolfram Sang <wsa+renesas-jBu1N2QxHDJrcw3mvpCnnVaTQe2KTcn/@public.gmane.org> Applied to for-next, thanks! ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-05-31 23:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-19 16:29 [PATCH] i2c: check for proper length of the reg property Wolfram Sang
[not found] ` <1432052988-6187-1-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
2015-05-20 2:20 ` Simon Horman
2015-05-31 23:30 ` Wolfram Sang
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).