From: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
To: Sudip Mukherjee
<sudipm.mukherjee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Tim Waugh <tim-xbtOLCSHb9Lk1uMJSBkQmQ@public.gmane.org>,
Jean Delvare <jdelvare-l3A5Bk7waGM@public.gmane.org>,
Willy Tarreau <willy-859RlTSWH48dnm+yROfE0A@public.gmane.org>,
Greg Kroah-Hartman
<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
Alan Cox
<gnomes-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b@public.gmane.org
Subject: Re: [PATCH 4/6] i2c-parport: use new parport device model
Date: Wed, 20 May 2015 19:35:17 +0200 [thread overview]
Message-ID: <20150520173516.GA1615@katana> (raw)
In-Reply-To: <20150520171452.GA9069@sudip-PC>
[-- Attachment #1: Type: text/plain, Size: 729 bytes --]
> > > static struct parport_driver i2c_parport_driver = {
> > > - .name = "i2c-parport",
> > > - .attach = i2c_parport_attach,
> > > - .detach = i2c_parport_detach,
> > > + .name = "i2c-parport",
> > > + .match_port = i2c_parport_attach,
> > > + .detach = i2c_parport_detach,
> > > + .devmodel = true,
> >
> > Minor nit: I prefer to not use tabs but a single space after the struct
> > member names. Less hazzle in the future and still readable IMO.
> It was having space originally. I changed that into tab as it was
> looking good with them as aligned.
> I will wait today for some more review and send v2 tomorrow with this
> chanage.
Thanks. Just to make sure: Keep it one space only, no alignment.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-05-20 17:35 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-20 15:26 [PATCH 0/6] use devicemodel with parport Sudip Mukherjee
2015-05-20 15:26 ` [PATCH 1/6] parport: add device-model to parport subsystem Sudip Mukherjee
2015-05-20 15:26 ` [PATCH 2/6] staging: panel: use new parport device model Sudip Mukherjee
2015-05-20 15:26 ` [PATCH 3/6] i2c-parport: define ports to connect Sudip Mukherjee
2015-05-20 15:46 ` Wolfram Sang
2015-05-20 15:27 ` [PATCH 4/6] i2c-parport: use new parport device model Sudip Mukherjee
2015-05-20 15:49 ` Wolfram Sang
2015-05-20 17:14 ` Sudip Mukherjee
2015-05-20 17:35 ` Wolfram Sang [this message]
2015-05-20 17:59 ` Jean Delvare
2015-05-21 1:02 ` [RFC PATCH] checkpatch: check for 2 or more spaces around assignment of a declaration Joe Perches
2015-05-21 5:48 ` Willy Tarreau
2015-05-21 6:16 ` [PATCH v2 4/6] i2c-parport: use new parport device model Sudip Mukherjee
2015-05-20 15:27 ` [PATCH 5/6] paride: " Sudip Mukherjee
2015-05-20 15:27 ` [PATCH 6/6] MAINTAINERS: maintain parport Sudip Mukherjee
2015-05-20 15:46 ` Richard Weinberger
2015-05-20 16:28 ` Joe Perches
2015-05-20 17:31 ` Sudip Mukherjee
2015-05-20 16:33 ` One Thousand Gnomes
2015-05-20 20:36 ` Richard Weinberger
[not found] ` <555CF034.5090704-/L3Ra7n9ekc@public.gmane.org>
2015-05-21 5:59 ` Sudip Mukherjee
2015-05-21 5:51 ` Willy Tarreau
2015-05-21 6:09 ` Greg Kroah-Hartman
2015-05-31 22:05 ` [PATCH 0/6] use devicemodel with parport Greg Kroah-Hartman
[not found] ` <20150531220530.GF13872-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2015-06-01 5:46 ` Sudip Mukherjee
2015-06-01 6:18 ` Greg Kroah-Hartman
[not found] ` <20150601061811.GA5103-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2015-06-01 8:34 ` Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150520173516.GA1615@katana \
--to=wsa-z923lk4zbo2bacvfa/9k2g@public.gmane.org \
--cc=devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b@public.gmane.org \
--cc=gnomes-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=jdelvare-l3A5Bk7waGM@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sudipm.mukherjee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=tim-xbtOLCSHb9Lk1uMJSBkQmQ@public.gmane.org \
--cc=willy-859RlTSWH48dnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).