From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean Delvare Subject: Re: [PATCH 4/6] i2c-parport: use new parport device model Date: Wed, 20 May 2015 19:59:18 +0200 Message-ID: <20150520195918.1c150979@endymion.delvare> References: <1432135622-8288-1-git-send-email-sudipm.mukherjee@gmail.com> <1432135622-8288-5-git-send-email-sudipm.mukherjee@gmail.com> <20150520154907.GB2001@katana> <20150520171452.GA9069@sudip-PC> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150520171452.GA9069@sudip-PC> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Sudip Mukherjee Cc: Wolfram Sang , Tim Waugh , Willy Tarreau , Greg Kroah-Hartman , Alan Cox , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b@public.gmane.org List-Id: linux-i2c@vger.kernel.org On Wed, 20 May 2015 22:44:52 +0530, Sudip Mukherjee wrote: > On Wed, May 20, 2015 at 05:49:07PM +0200, Wolfram Sang wrote: > > On Wed, May 20, 2015 at 08:57:00PM +0530, Sudip Mukherjee wrote: > > > static struct parport_driver i2c_parport_driver = { > > > - .name = "i2c-parport", > > > - .attach = i2c_parport_attach, > > > - .detach = i2c_parport_detach, > > > + .name = "i2c-parport", > > > + .match_port = i2c_parport_attach, > > > + .detach = i2c_parport_detach, > > > + .devmodel = true, > > > > Minor nit: I prefer to not use tabs but a single space after the struct > > member names. Less hazzle in the future and still readable IMO. > > It was having space originally. I changed that into tab as it was > looking good with them as aligned. As the driver maintainer, I am fine with both unaligned or tab-aligned. Space-aligned as I did originally was not a good idea, I admit. -- Jean Delvare SUSE L3 Support