From: Wolfram Sang <wsa@the-dreams.de>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: Cyrille Pitchen <cyrille.pitchen@atmel.com>,
nicolas.ferre@atmel.com, linux-i2c@vger.kernel.org,
mark.rutland@arm.com, devicetree@vger.kernel.org,
pawel.moll@arm.com, ijc+devicetree@hellion.org.uk,
linux-kernel@vger.kernel.org, robh+dt@kernel.org,
galak@codeaurora.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v6 5/6] i2c: at91: print hardware version
Date: Wed, 10 Jun 2015 21:15:20 +0900 [thread overview]
Message-ID: <20150610121519.GB1592@katana> (raw)
In-Reply-To: <55782935.30608@cogentembedded.com>
[-- Attachment #1: Type: text/plain, Size: 441 bytes --]
> >>>- dev_info(dev->dev, "AT91 i2c bus driver.\n");
> >>>+ dev_info(dev->dev, "AT91 i2c bus driver (version: %#x).\n",
>
> >> It looks as if you rather print the driver's version. :-)
>
> > From my point of view, having a version number for a Linux driver would
> >be strange
>
> Not everybody shares your opinion.
I tend to agree with Sergei but let's keep things simple: I'll make it
"hw version" before applying.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-06-10 12:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-09 16:22 [PATCH v6 0/6] i2c: at91: add support to FIFOs and alternative command Cyrille Pitchen
[not found] ` <cover.1433866582.git.cyrille.pitchen-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2015-06-09 16:22 ` [PATCH v6 1/6] i2c: at91: fix a race condition when using the DMA controller Cyrille Pitchen
2015-06-09 16:22 ` [PATCH v6 2/6] i2c: at91: use BIT() macro to define register bits Cyrille Pitchen
2015-06-09 16:22 ` [PATCH v6 4/6] i2c: at91: add support for new alternative command mode Cyrille Pitchen
2015-06-09 16:22 ` [PATCH v6 5/6] i2c: at91: print hardware version Cyrille Pitchen
[not found] ` <d1fbf4bce3b470409ef3198f551cfc3f8f22ac78.1433866582.git.cyrille.pitchen-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2015-06-09 19:46 ` Sergei Shtylyov
[not found] ` <5577428C.3090206-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2015-06-10 8:05 ` Ludovic Desroches
2015-06-10 12:10 ` Sergei Shtylyov
2015-06-10 12:15 ` Wolfram Sang [this message]
2015-06-09 16:22 ` [PATCH v6 6/6] i2c: at91: add support to FIFOs Cyrille Pitchen
2015-06-09 16:22 ` [PATCH v6 3/6] i2c: at91: update documentation for DT bindings Cyrille Pitchen
2015-06-10 12:57 ` [PATCH v6 0/6] i2c: at91: add support to FIFOs and alternative command Wolfram Sang
2015-06-10 13:09 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150610121519.GB1592@katana \
--to=wsa@the-dreams.de \
--cc=cyrille.pitchen@atmel.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nicolas.ferre@atmel.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).