From: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
To: Shubhrajyoti Datta
<shubhrajyoti.datta-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Shubhrajyoti Datta
<shubhraj-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH 1/9] i2c: xiic: Do not continue in case of errors in Rx
Date: Wed, 17 Jun 2015 13:42:00 +0200 [thread overview]
Message-ID: <20150617114159.GA4604@schokonusskuchen.bad> (raw)
In-Reply-To: <1434381480-3042-1-git-send-email-shubhraj-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 586 bytes --]
Hi,
On Mon, Jun 15, 2015 at 08:47:52PM +0530, Shubhrajyoti Datta wrote:
> Handle error cases in the Rx path
>
> Signed-off-by: Shubhrajyoti Datta <shubhraj-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
Your patch descriptions need improvement. They describe what you do,
but this can be seen in the patch as well. What you need to describe is
WHY you need this change. What was wrong before, what is better now.
Because this driver is long in use, we must be very careful about
regressions and every change needs a good reason.
So, please rework your patch descriptions.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2015-06-17 11:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-15 15:17 [PATCH 1/9] i2c: xiic: Do not continue in case of errors in Rx Shubhrajyoti Datta
[not found] ` <1434381480-3042-1-git-send-email-shubhraj-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
2015-06-15 15:17 ` [PATCH 2/9] i2c: xiic: Remove the disabling of interrupts Shubhrajyoti Datta
2015-06-15 15:17 ` [PATCH 3/9] i2c: xiic: move the xiic_process to thread context Shubhrajyoti Datta
2015-06-15 15:17 ` [PATCH 4/9] i2c: xiic: Do not reset controller before every transfer Shubhrajyoti Datta
2015-06-15 15:17 ` [PATCH 5/9] i2c: xiic: Remove the disabling of interrupts Shubhrajyoti Datta
2015-06-15 15:17 ` [PATCH 6/9] i2c: xiic: Remove busy loop while waiting for bus busy Shubhrajyoti Datta
2015-06-15 15:17 ` [PATCH 7/9] i2c: xiic: Add a msg in case of timeout Shubhrajyoti Datta
2015-06-15 15:17 ` [PATCH 8/9] i2c: xiic: Remove the Addressed as slave interrupt Shubhrajyoti Datta
2015-06-15 15:18 ` [PATCH 9/9] i2c: xiic: Service all interrupts in isr Shubhrajyoti Datta
2015-06-17 11:42 ` Wolfram Sang [this message]
[not found] ` <20150617114159.GA4604-oo5tB6JMkjKRinMKxDlMNPwbnWRJjS81@public.gmane.org>
2015-06-17 12:38 ` [PATCH 1/9] i2c: xiic: Do not continue in case of errors in Rx Shubhrajyoti Datta
[not found] ` <4EED9C67BE3EF440A606099F8E34C52862BB72-4lKfpRxZ5enZMOc0yg5rMog+Gb3gawCHQz34XiSyOiE@public.gmane.org>
2015-06-17 12:44 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150617114159.GA4604@schokonusskuchen.bad \
--to=wsa-z923lk4zbo2bacvfa/9k2g@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=shubhraj-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org \
--cc=shubhrajyoti.datta-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).