From: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
To: Gao Pandy <gaopan-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
Cc: "Uwe Kleine-König"
<u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
"linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"Li Frank" <Frank.Li-KZfg59tc24xl57MIdRCFDg@public.gmane.org>,
"Duan Andy" <fugang.duan-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
Subject: Re: [Patch v1] i2c: imx: add runtime pm support to improve the performance
Date: Thu, 18 Jun 2015 06:24:29 +0200 [thread overview]
Message-ID: <20150618042427.GA1611@katana> (raw)
In-Reply-To: <CY1PR0301MB0858E745717A1A7317909A2FCFA50-YrwGdl+PljlUWoKpOwApjpwN6zqB+hSMnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 619 bytes --]
> > > + if (pm_runtime_suspended(i2c_imx->adapter.dev.parent))
> > > + return IRQ_NONE;
> > > +
> > I don't claim to understand the runtime pm stuff, but I agree to the
> > previous reviewer that this smells fishy. If this is required it needs a
> > comment why.
> >
> In fact, I agree you two reviewers' consideration. As I said, this is just to avoid system hang in worse case.
> Of course, I still don't catch the worse case. So I will remove this pm stuff.
So, there is a worst case where the system can hang now which is not
present in the current version of this driver (i.e. before your patch)?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-06-18 4:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-11 1:50 [Patch v1] i2c: imx: add runtime pm support to improve the performance Gao Pan
[not found] ` <1433987404-28957-1-git-send-email-b54642-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2015-06-11 9:29 ` Shubhrajyoti Datta
[not found] ` <CAM=Q2cuEChJySEex99e_xqfgXORZxDHqpGve7hbh-+nQVYPxAg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-06-11 9:36 ` Duan Andy
[not found] ` <BLUPR03MB373DE1F76EE2A0B96A66FC9F5BC0-GeMU99GfrrsHjcGqcGfFzOO6mTEJWrR4XA4E9RH9d+qIuWR1G4zioA@public.gmane.org>
2015-06-11 10:10 ` Shubhrajyoti Datta
[not found] ` <CAM=Q2cuyhhH+_HY8Fdwt35W2y_oNb+t2P12eMeZKGJsxLxq=Hw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-06-11 10:20 ` Duan Andy
2015-06-17 21:48 ` Uwe Kleine-König
[not found] ` <20150617214839.GG20984-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2015-06-18 2:37 ` Gao Pandy
[not found] ` <CY1PR0301MB0858E745717A1A7317909A2FCFA50-YrwGdl+PljlUWoKpOwApjpwN6zqB+hSMnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2015-06-18 4:24 ` Wolfram Sang [this message]
2015-06-18 6:15 ` Gao Pandy
[not found] <BLUPR03MB37397FD1C002F3EF117C9F3F5B80@BLUPR03MB373.namprd03.prod.outlook.com>
[not found] ` <BLUPR03MB37397FD1C002F3EF117C9F3F5B80-GeMU99GfrrsHjcGqcGfFzOO6mTEJWrR4XA4E9RH9d+qIuWR1G4zioA@public.gmane.org>
2015-06-15 4:38 ` Gao Pandy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150618042427.GA1611@katana \
--to=wsa-z923lk4zbo2bacvfa/9k2g@public.gmane.org \
--cc=Frank.Li-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
--cc=fugang.duan-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
--cc=gaopan-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox