Re: [RFC] i2c-tools: allow linker and compile flags from command line

[Jean Delvare <jdelvare-l3A5Bk7waGM@public.gmane.org>]

Hi Wolfram,

On Fri, 19 Jun 2015 11:24:32 +0200, Wolfram Sang wrote:
> Mainly for debugging, so one can pass stuff like -O0 or -static.
> 
> Signed-off-by: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
> ---
>  tools/Module.mk | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/Module.mk b/tools/Module.mk
> index 8efddbb..641ac81 100644
> --- a/tools/Module.mk
> +++ b/tools/Module.mk
> @@ -9,13 +9,13 @@
>  
>  TOOLS_DIR	:= tools
>  
> -TOOLS_CFLAGS	:= -Wstrict-prototypes -Wshadow -Wpointer-arith -Wcast-qual \
> +TOOLS_CFLAGS	+= -Wstrict-prototypes -Wshadow -Wpointer-arith -Wcast-qual \
>  		   -Wcast-align -Wwrite-strings -Wnested-externs -Winline \
>  		   -W -Wundef -Wmissing-prototypes -Iinclude
>  ifeq ($(USE_STATIC_LIB),1)
> -TOOLS_LDFLAGS	:= $(LIB_DIR)/$(LIB_STLIBNAME)
> +TOOLS_LDFLAGS	+= $(LIB_DIR)/$(LIB_STLIBNAME)
>  else
> -TOOLS_LDFLAGS	:= -Llib -li2c
> +TOOLS_LDFLAGS	+= -Llib -li2c

Note that -Llib has become -L$(LIB_DIR) meanwhile.

>  endif
>  
>  TOOLS_TARGETS	:= i2cdetect i2cdump i2cset i2cget

You can already overwrite CFLAGS and LDFLAGS on the command line, and
this works for the whole package. Do you really need to set different
CFLAGS (or LDFLAGS) for different parts of i2c-tools? Seems overkill to
me.

If you really need that then this should be done consistently for all
"modules": not just tools but also lib and now eeprog.

-- 
Jean Delvare
SUSE L3 Support