From: Wolfram Sang <wsa@the-dreams.de>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Jean Delvare <jdelvare@suse.de>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] i2c-parport: start using pr_fmt
Date: Thu, 9 Jul 2015 22:04:05 +0200 [thread overview]
Message-ID: <20150709200405.GK4744@katana> (raw)
In-Reply-To: <1434632627-18955-2-git-send-email-sudipm.mukherjee@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 526 bytes --]
On Thu, Jun 18, 2015 at 06:33:47PM +0530, Sudip Mukherjee wrote:
> Start using pr_fmt and convert all remaining printk to use
> pr_* family of macros.
>
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Applied to for-next, thanks!
One modification:
> adapter = kzalloc(sizeof(struct i2c_par), GFP_KERNEL);
> if (adapter == NULL) {
> - printk(KERN_ERR "i2c-parport: Failed to kzalloc\n");
> + pr_err("Failed to kzalloc\n");
I removed this printout, since we get a dump in this case anyhow.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-07-09 20:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-18 13:03 [PATCH 1/2] i2c-parport: use dev_* Sudip Mukherjee
[not found] ` <1434632627-18955-1-git-send-email-sudipm.mukherjee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-06-18 13:03 ` [PATCH 2/2] i2c-parport: start using pr_fmt Sudip Mukherjee
2015-07-09 20:04 ` Wolfram Sang [this message]
2015-07-09 20:02 ` [PATCH 1/2] i2c-parport: use dev_* Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150709200405.GK4744@katana \
--to=wsa@the-dreams.de \
--cc=jdelvare@suse.de \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).