linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] i2c: xgene-slimpro: Fix missing mbox_free_channel call in probe error path
@ 2015-06-30  3:08 Axel Lin
       [not found] ` <1435633726.14315.1.camel-8E1dMatC8ynQT0dZR+AlfA@public.gmane.org>
  0 siblings, 1 reply; 3+ messages in thread
From: Axel Lin @ 2015-06-30  3:08 UTC (permalink / raw)
  To: Wolfram Sang; +Cc: Feng Kan, Hieu Le, linux-i2c-u79uwXL29TY76Z2rM5mHXA

Free requested mailbox channel before return error.

Signed-off-by: Axel Lin <axel.lin-8E1dMatC8ynQT0dZR+AlfA@public.gmane.org>
---
 drivers/i2c/busses/i2c-xgene-slimpro.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/i2c/busses/i2c-xgene-slimpro.c b/drivers/i2c/busses/i2c-xgene-slimpro.c
index dcca707..1c9cb65a 100644
--- a/drivers/i2c/busses/i2c-xgene-slimpro.c
+++ b/drivers/i2c/busses/i2c-xgene-slimpro.c
@@ -419,6 +419,7 @@ static int xgene_slimpro_i2c_probe(struct platform_device *pdev)
 	rc = i2c_add_adapter(adapter);
 	if (rc) {
 		dev_err(&pdev->dev, "Adapter registeration failed\n");
+		mbox_free_channel(ctx->mbox_chan);
 		return rc;
 	}
 
-- 
2.1.0

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] i2c: xgene-slimpro: Fix missing mbox_free_channel call in probe error path
       [not found] ` <1435633726.14315.1.camel-8E1dMatC8ynQT0dZR+AlfA@public.gmane.org>
@ 2015-07-09 20:14   ` Wolfram Sang
  2015-07-09 20:17     ` Wolfram Sang
  0 siblings, 1 reply; 3+ messages in thread
From: Wolfram Sang @ 2015-07-09 20:14 UTC (permalink / raw)
  To: Axel Lin; +Cc: Feng Kan, Hieu Le, linux-i2c-u79uwXL29TY76Z2rM5mHXA

[-- Attachment #1: Type: text/plain, Size: 230 bytes --]

On Tue, Jun 30, 2015 at 11:08:46AM +0800, Axel Lin wrote:
> Free requested mailbox channel before return error.
> 
> Signed-off-by: Axel Lin <axel.lin-8E1dMatC8ynQT0dZR+AlfA@public.gmane.org>

Applied to for-next, thanks!


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] i2c: xgene-slimpro: Fix missing mbox_free_channel call in probe error path
  2015-07-09 20:14   ` Wolfram Sang
@ 2015-07-09 20:17     ` Wolfram Sang
  0 siblings, 0 replies; 3+ messages in thread
From: Wolfram Sang @ 2015-07-09 20:17 UTC (permalink / raw)
  To: Axel Lin; +Cc: Feng Kan, Hieu Le, linux-i2c-u79uwXL29TY76Z2rM5mHXA

[-- Attachment #1: Type: text/plain, Size: 350 bytes --]

On Thu, Jul 09, 2015 at 10:14:22PM +0200, Wolfram Sang wrote:
> On Tue, Jun 30, 2015 at 11:08:46AM +0800, Axel Lin wrote:
> > Free requested mailbox channel before return error.
> > 
> > Signed-off-by: Axel Lin <axel.lin-8E1dMatC8ynQT0dZR+AlfA@public.gmane.org>
> 
> Applied to for-next, thanks!

for-current, I mean. Sorry for the noise.


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-07-09 20:17 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-30  3:08 [PATCH] i2c: xgene-slimpro: Fix missing mbox_free_channel call in probe error path Axel Lin
     [not found] ` <1435633726.14315.1.camel-8E1dMatC8ynQT0dZR+AlfA@public.gmane.org>
2015-07-09 20:14   ` Wolfram Sang
2015-07-09 20:17     ` Wolfram Sang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).