From: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
To: Antonio Borneo <borneo.antonio-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Jiri Kosina <jkosina-IBi9RG/b67k@public.gmane.org>,
Ellen Wang
<ellen-qUQiAmfTcIp+XZJcv9eMoEEOCMrvLtNR@public.gmane.org>,
David Barksdale
<dbarksdale-2SNLKkHU5xRBDgjK7y7TUQ@public.gmane.org>,
linux-input <linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v2] HID: cp2112: fix I2C_SMBUS_BYTE write
Date: Tue, 14 Jul 2015 17:49:39 +0200 [thread overview]
Message-ID: <20150714154939.GA20875@katana> (raw)
In-Reply-To: <CAAj6DX2_ZwFqpKD5JjbWuJw7SJv3G+DhpnD6tZAoDcF32GQ=0Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 431 bytes --]
> This is a MFD; should be split in GPIO and I2C, then each part moved
> in its respective tree.
Yes, this is the conclusion we drew last time, too. It might seem
overkill for such simple devices, still this case shows how much drivers
can suffer if missing the expertise of the apropriate subsystem. That
being said, world is full of cornercases, I agree.
> Anyone already working in this direction?
I'd be very surprised :)
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-07-14 15:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-13 22:23 [PATCH v2] HID: cp2112: fix I2C_SMBUS_BYTE write Ellen Wang
2015-07-14 8:46 ` Antonio Borneo
[not found] ` <1436826234-2447-1-git-send-email-ellen-qUQiAmfTcIp+XZJcv9eMoEEOCMrvLtNR@public.gmane.org>
2015-07-14 11:49 ` Wolfram Sang
2015-07-14 12:54 ` Jiri Kosina
[not found] ` <alpine.LNX.2.00.1507141452140.7522-ztGlSCb7Y1iN3ZZ/Hiejyg@public.gmane.org>
2015-07-14 13:36 ` Antonio Borneo
[not found] ` <CAAj6DX2_ZwFqpKD5JjbWuJw7SJv3G+DhpnD6tZAoDcF32GQ=0Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-07-14 15:49 ` Wolfram Sang [this message]
2015-07-14 22:51 ` Ellen Wang
2015-07-14 22:54 ` Ellen Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150714154939.GA20875@katana \
--to=wsa-z923lk4zbo2bacvfa/9k2g@public.gmane.org \
--cc=borneo.antonio-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=dbarksdale-2SNLKkHU5xRBDgjK7y7TUQ@public.gmane.org \
--cc=ellen-qUQiAmfTcIp+XZJcv9eMoEEOCMrvLtNR@public.gmane.org \
--cc=jkosina-IBi9RG/b67k@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox