* [PATCH] i2c-parport: Add VCT-jig adapter
@ 2015-07-13 17:31 Ondrej Zary
[not found] ` <1436808672-15503-1-git-send-email-linux-ZCIryABCsrmttCpgsWEBFmD2FQJk+8+b@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Ondrej Zary @ 2015-07-13 17:31 UTC (permalink / raw)
To: Jean Delvare; +Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA, Kernel development list
Add support for VCT-jig parallel port I2C adapter to i2c-parport.
The adapter schematic can be found here (in the RAR file):
http://remont-aud.net/shop/22/desc/vct-jig-komplekt-dlja-samostojatelnoj-sborki
Signed-off-by: Ondrej Zary <linux-ZCIryABCsrmttCpgsWEBFmD2FQJk+8+b@public.gmane.org>
---
Documentation/i2c/busses/i2c-parport | 1 +
drivers/i2c/busses/i2c-parport.h | 8 ++++++++
2 files changed, 9 insertions(+)
diff --git a/Documentation/i2c/busses/i2c-parport b/Documentation/i2c/busses/i2c-parport
index 0e2d17b..c3dbb3b 100644
--- a/Documentation/i2c/busses/i2c-parport
+++ b/Documentation/i2c/busses/i2c-parport
@@ -20,6 +20,7 @@ It currently supports the following devices:
* (type=5) Analog Devices evaluation boards: ADM1025, ADM1030, ADM1031
* (type=6) Barco LPT->DVI (K5800236) adapter
* (type=7) One For All JP1 parallel port adapter
+ * (type=8) VCT-jig
These devices use different pinout configurations, so you have to tell
the driver what you have, using the type module parameter. There is no
diff --git a/drivers/i2c/busses/i2c-parport.h b/drivers/i2c/busses/i2c-parport.h
index 4e12945..84a6616 100644
--- a/drivers/i2c/busses/i2c-parport.h
+++ b/drivers/i2c/busses/i2c-parport.h
@@ -89,6 +89,13 @@ static const struct adapter_parm adapter_parm[] = {
.getsda = { 0x80, PORT_STAT, 1 },
.init = { 0x04, PORT_DATA, 1 },
},
+ /* type 8: VCT-jig */
+ {
+ .setsda = { 0x04, PORT_DATA, 1 },
+ .setscl = { 0x01, PORT_DATA, 1 },
+ .getsda = { 0x40, PORT_STAT, 0 },
+ .getscl = { 0x80, PORT_STAT, 1 },
+ },
};
static int type = -1;
@@ -103,4 +110,5 @@ MODULE_PARM_DESC(type,
" 5 = ADM1025, ADM1030 and ADM1031 evaluation boards\n"
" 6 = Barco LPT->DVI (K5800236) adapter\n"
" 7 = One For All JP1 parallel port adapter\n"
+ " 8 = VCT-jig\n"
);
--
Ondrej Zary
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] i2c-parport: Add VCT-jig adapter
[not found] ` <1436808672-15503-1-git-send-email-linux-ZCIryABCsrmttCpgsWEBFmD2FQJk+8+b@public.gmane.org>
@ 2015-07-16 12:53 ` Jean Delvare
2015-07-31 11:24 ` Wolfram Sang
1 sibling, 0 replies; 3+ messages in thread
From: Jean Delvare @ 2015-07-16 12:53 UTC (permalink / raw)
To: Ondrej Zary; +Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA, Kernel development list
On Mon, 13 Jul 2015 19:31:12 +0200, Ondrej Zary wrote:
> Add support for VCT-jig parallel port I2C adapter to i2c-parport.
>
> The adapter schematic can be found here (in the RAR file):
> http://remont-aud.net/shop/22/desc/vct-jig-komplekt-dlja-samostojatelnoj-sborki
>
> Signed-off-by: Ondrej Zary <linux-ZCIryABCsrmttCpgsWEBFmD2FQJk+8+b@public.gmane.org>
> ---
> Documentation/i2c/busses/i2c-parport | 1 +
> drivers/i2c/busses/i2c-parport.h | 8 ++++++++
> 2 files changed, 9 insertions(+)
>
> diff --git a/Documentation/i2c/busses/i2c-parport b/Documentation/i2c/busses/i2c-parport
> index 0e2d17b..c3dbb3b 100644
> --- a/Documentation/i2c/busses/i2c-parport
> +++ b/Documentation/i2c/busses/i2c-parport
> @@ -20,6 +20,7 @@ It currently supports the following devices:
> * (type=5) Analog Devices evaluation boards: ADM1025, ADM1030, ADM1031
> * (type=6) Barco LPT->DVI (K5800236) adapter
> * (type=7) One For All JP1 parallel port adapter
> + * (type=8) VCT-jig
>
> These devices use different pinout configurations, so you have to tell
> the driver what you have, using the type module parameter. There is no
> diff --git a/drivers/i2c/busses/i2c-parport.h b/drivers/i2c/busses/i2c-parport.h
> index 4e12945..84a6616 100644
> --- a/drivers/i2c/busses/i2c-parport.h
> +++ b/drivers/i2c/busses/i2c-parport.h
> @@ -89,6 +89,13 @@ static const struct adapter_parm adapter_parm[] = {
> .getsda = { 0x80, PORT_STAT, 1 },
> .init = { 0x04, PORT_DATA, 1 },
> },
> + /* type 8: VCT-jig */
> + {
> + .setsda = { 0x04, PORT_DATA, 1 },
> + .setscl = { 0x01, PORT_DATA, 1 },
> + .getsda = { 0x40, PORT_STAT, 0 },
> + .getscl = { 0x80, PORT_STAT, 1 },
> + },
> };
>
> static int type = -1;
> @@ -103,4 +110,5 @@ MODULE_PARM_DESC(type,
> " 5 = ADM1025, ADM1030 and ADM1031 evaluation boards\n"
> " 6 = Barco LPT->DVI (K5800236) adapter\n"
> " 7 = One For All JP1 parallel port adapter\n"
> + " 8 = VCT-jig\n"
> );
Looks good.
Reviewed-by: Jean Delvare <jdelvare-l3A5Bk7waGM@public.gmane.org>
--
Jean Delvare
SUSE L3 Support
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] i2c-parport: Add VCT-jig adapter
[not found] ` <1436808672-15503-1-git-send-email-linux-ZCIryABCsrmttCpgsWEBFmD2FQJk+8+b@public.gmane.org>
2015-07-16 12:53 ` Jean Delvare
@ 2015-07-31 11:24 ` Wolfram Sang
1 sibling, 0 replies; 3+ messages in thread
From: Wolfram Sang @ 2015-07-31 11:24 UTC (permalink / raw)
To: Ondrej Zary
Cc: Jean Delvare, linux-i2c-u79uwXL29TY76Z2rM5mHXA,
Kernel development list
[-- Attachment #1: Type: text/plain, Size: 406 bytes --]
On Mon, Jul 13, 2015 at 07:31:12PM +0200, Ondrej Zary wrote:
> Add support for VCT-jig parallel port I2C adapter to i2c-parport.
>
> The adapter schematic can be found here (in the RAR file):
> http://remont-aud.net/shop/22/desc/vct-jig-komplekt-dlja-samostojatelnoj-sborki
>
> Signed-off-by: Ondrej Zary <linux-ZCIryABCsrmttCpgsWEBFmD2FQJk+8+b@public.gmane.org>
Applied to for-next, thanks!
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-07-31 11:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-13 17:31 [PATCH] i2c-parport: Add VCT-jig adapter Ondrej Zary
[not found] ` <1436808672-15503-1-git-send-email-linux-ZCIryABCsrmttCpgsWEBFmD2FQJk+8+b@public.gmane.org>
2015-07-16 12:53 ` Jean Delvare
2015-07-31 11:24 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).