From: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
To: Vladimir Zapolskiy
<vladimir_zapolskiy-nmGgyN9QBj3QT0dZR+AlfA@public.gmane.org>
Cc: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Doug Anderson <dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Subject: Re: [PATCH v2 4/4] i2c: arb-gpio-challenge: use of_get_i2c_adapter_by_node interface
Date: Thu, 6 Aug 2015 02:51:51 +0200 [thread overview]
Message-ID: <20150806005151.GD1743@katana> (raw)
In-Reply-To: <1438007451-8553-5-git-send-email-vladimir_zapolskiy-nmGgyN9QBj3QT0dZR+AlfA@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 734 bytes --]
On Mon, Jul 27, 2015 at 05:30:51PM +0300, Vladimir Zapolskiy wrote:
> This change is needed to properly lock I2C parent bus driver.
>
> Prior to this change i2c_put_adapter() is misused, which may lead
> to an overflow over zero of I2C bus driver user counter.
>
> By the way added a missing of_node_put() to eliminate memory leak,
> if OF_DYNAMIC is enabled.
>
> Signed-off-by: Vladimir Zapolskiy <vladimir_zapolskiy-nmGgyN9QBj3QT0dZR+AlfA@public.gmane.org>
> Cc: Doug Anderson <dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Applied to for-next! However...
> + of_node_put(parent_np);
I removed this line. Please resend this as a seperate patch since it
fixes a seperate issue.
Thanks,
Wolfram
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-08-06 0:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-27 14:30 [PATCH v2 0/4] i2c: fix i2c adapter device driver user counter Vladimir Zapolskiy
[not found] ` <1438007451-8553-1-git-send-email-vladimir_zapolskiy-nmGgyN9QBj3QT0dZR+AlfA@public.gmane.org>
2015-07-27 14:30 ` [PATCH v2 1/4] i2c: core: fix leaked device refcount on of_find_i2c_* error path Vladimir Zapolskiy
[not found] ` <1438007451-8553-2-git-send-email-vladimir_zapolskiy-nmGgyN9QBj3QT0dZR+AlfA@public.gmane.org>
2015-08-01 10:09 ` Wolfram Sang
2015-07-27 14:30 ` [PATCH v2 2/4] i2c: core: manage i2c bus device refcount in i2c_[get|put]_adapter Vladimir Zapolskiy
[not found] ` <1438007451-8553-3-git-send-email-vladimir_zapolskiy-nmGgyN9QBj3QT0dZR+AlfA@public.gmane.org>
2015-08-06 0:50 ` Wolfram Sang
2015-07-27 14:30 ` [PATCH v2 3/4] i2c: core: add and export of_get_i2c_adapter_by_node() interface Vladimir Zapolskiy
[not found] ` <1438007451-8553-4-git-send-email-vladimir_zapolskiy-nmGgyN9QBj3QT0dZR+AlfA@public.gmane.org>
2015-08-06 0:50 ` Wolfram Sang
2015-07-27 14:30 ` [PATCH v2 4/4] i2c: arb-gpio-challenge: use of_get_i2c_adapter_by_node interface Vladimir Zapolskiy
[not found] ` <1438007451-8553-5-git-send-email-vladimir_zapolskiy-nmGgyN9QBj3QT0dZR+AlfA@public.gmane.org>
2015-08-06 0:51 ` Wolfram Sang [this message]
2015-08-06 10:18 ` Vladimir Zapolskiy
2015-08-01 10:09 ` [PATCH v2 0/4] i2c: fix i2c adapter device driver user counter Wolfram Sang
2015-08-01 23:37 ` Vladimir Zapolskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150806005151.GD1743@katana \
--to=wsa-z923lk4zbo2bacvfa/9k2g@public.gmane.org \
--cc=dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=vladimir_zapolskiy-nmGgyN9QBj3QT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).