From: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
To: Colin King <colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] i2c: viperboard: clean up inconsistent indenting
Date: Sun, 9 Aug 2015 17:29:45 +0200 [thread overview]
Message-ID: <20150809152944.GB2367@katana> (raw)
In-Reply-To: <1437134483-18286-1-git-send-email-colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1332 bytes --]
On Fri, Jul 17, 2015 at 01:01:23PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
>
> Minor clean up of indenting, no functional change
>
> Signed-off-by: Colin Ian King <colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
> ---
Applied to for-next, thanks!
> drivers/i2c/busses/i2c-viperboard.c | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-viperboard.c b/drivers/i2c/busses/i2c-viperboard.c
> index 47e88ad..30cce15 100644
> --- a/drivers/i2c/busses/i2c-viperboard.c
> +++ b/drivers/i2c/busses/i2c-viperboard.c
> @@ -391,11 +391,12 @@ static int vprbrd_i2c_probe(struct platform_device *pdev)
> VPRBRD_USB_REQUEST_I2C_FREQ, VPRBRD_USB_TYPE_OUT,
> 0x0000, 0x0000, &vb_i2c->bus_freq_param, 1,
> VPRBRD_USB_TIMEOUT_MS);
> - if (ret != 1) {
> - dev_err(&pdev->dev,
> - "failure setting i2c_bus_freq to %d\n", i2c_bus_freq);
> - return -EIO;
> - }
> + if (ret != 1) {
> + dev_err(&pdev->dev,
> + "failure setting i2c_bus_freq to %d\n",
Squashed those two lines into one, though.
> + i2c_bus_freq);
> + return -EIO;
> + }
> } else {
> dev_err(&pdev->dev,
> "invalid i2c_bus_freq setting:%d\n", i2c_bus_freq);
> --
> 2.1.4
>
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2015-08-09 15:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-17 12:01 [PATCH] i2c: viperboard: clean up inconsistent indenting Colin King
[not found] ` <1437134483-18286-1-git-send-email-colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
2015-08-09 15:29 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150809152944.GB2367@katana \
--to=wsa-z923lk4zbo2bacvfa/9k2g@public.gmane.org \
--cc=colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox