linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
To: Crt Mori <cmo-fc6wVz46lShBDgjK7y7TUQ@public.gmane.org>
Cc: "Simon G. Vogl"
	<simon-nD9nYVNVf00W+b/DJNNodF6hYfS7NtTn@public.gmane.org>,
	linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] i2c: core: add support for read commands longer than byte
Date: Mon, 10 Aug 2015 12:34:05 +0200	[thread overview]
Message-ID: <20150810103405.GA5698@katana> (raw)
In-Reply-To: <CAKv63usQZBqjcAWFEpFvkRuGLd7JXcJh=5aKmd8B94A68dsZ7w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 1018 bytes --]

On Mon, Aug 10, 2015 at 12:06:07PM +0200, Crt Mori wrote:
> On 10 August 2015 at 11:13, Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org> wrote:
> >
> >
> > > This debate is what I wanted to have. The new Melexis sensor will be
> > > using it and since I think some others might also be using it in
> > > future I would rather put it to i2c. It is more i2c command than
> > > sensor specific so I think it fits into i2c.
> >
> > There is no thing as 'I2C command'. There are just I2C messages combined
> > into a transfer. I think you mix SMBus and I2C terminology here.
> >
> This is true, but write/read sequence can also be a request/reply
> which is basically a command for reading.

This interpretation is already a layer above. In I2C, you send a message
and then you receive one.

> Same function as my exists in: ./drivers/base/regmap/regmap-i2c.c ,
> maybe it is better just to use that?

Yes! Should have thought of that. Plus, you get more benefits like
caching if you want.

Case closed, thanks!


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

      parent reply	other threads:[~2015-08-10 10:34 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-24 13:20 [PATCH] i2c: core: add support for read commands longer than byte Crt Mori
     [not found] ` <1437744042-24471-1-git-send-email-cmo-fc6wVz46lShBDgjK7y7TUQ@public.gmane.org>
2015-08-04 11:16   ` Crt Mori
2015-08-09  7:40   ` Wolfram Sang
2015-08-10  7:26     ` Crt Mori
     [not found]       ` <CAKv63usiWb4QgV=pnwuqFJtTogRca7UjtmiSKV69OTM2h7LtHw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-08-10  7:55         ` Crt Mori
2015-08-10  9:13         ` Wolfram Sang
2015-08-10 10:06           ` Crt Mori
     [not found]             ` <CAKv63usQZBqjcAWFEpFvkRuGLd7JXcJh=5aKmd8B94A68dsZ7w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-08-10 10:34               ` Wolfram Sang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150810103405.GA5698@katana \
    --to=wsa-z923lk4zbo2bacvfa/9k2g@public.gmane.org \
    --cc=cmo-fc6wVz46lShBDgjK7y7TUQ@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=simon-nD9nYVNVf00W+b/DJNNodF6hYfS7NtTn@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).