From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean Delvare Subject: [PATCH] watchdog: iTCO_wdt: Fix unmet dependency in select Date: Fri, 25 Sep 2015 10:10:45 +0200 Message-ID: <20150925101045.06062b59@endymion.delvare> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de ([195.135.220.15]:41461 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753483AbbIYIKu (ORCPT ); Fri, 25 Sep 2015 04:10:50 -0400 Sender: linux-i2c-owner@vger.kernel.org List-Id: linux-i2c@vger.kernel.org To: linux-watchdog@vger.kernel.org Cc: Linux I2C , Jim Davis , Matt Fleming , Guenter Roeck , Lee Jones , Wim Van Sebroeck ITCO_WDT selects I2C_I801 but does not select its dependencies (I2C.) This can result in link-time failures: drivers/built-in.o: In function `i801_remove': i2c-i801.c:(.text+0x1a6126): undefined reference to `i2c_del_adapter' drivers/built-in.o: In function `dmi_check_onboard_devices': i2c-i801.c:(.text+0x1a7531): undefined reference to `i2c_new_device' drivers/built-in.o: In function `i801_probe': i2c-i801.c:(.text+0x1a7aa8): undefined reference to `i2c_add_adapter' i2c-i801.c:(.text+0x1a7e14): undefined reference to `i2c_new_device' So we must select I2C as well. Reported-by: Jim Davis Signed-off-by: Jean Delvare Fixes: 2a7a0e9bf7 ("watchdog: iTCO_wdt: Add support for TCO on Intel Sunrisepoint") Cc: Matt Fleming Cc: Guenter Roeck Cc: Lee Jones Cc: Wim Van Sebroeck --- drivers/watchdog/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-4.3-rc2.orig/drivers/watchdog/Kconfig 2015-09-24 11:43:29.959432358 +0200 +++ linux-4.3-rc2/drivers/watchdog/Kconfig 2015-09-25 09:56:20.518840112 +0200 @@ -818,6 +818,7 @@ config ITCO_WDT depends on (X86 || IA64) && PCI select WATCHDOG_CORE select LPC_ICH if !EXPERT + select I2C if !EXPERT select I2C_I801 if !EXPERT ---help--- Hardware driver for the intel TCO timer based watchdog devices. -- Jean Delvare SUSE L3 Support