From: Wolfram Sang <wsa@the-dreams.de>
To: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Cc: linux-i2c@vger.kernel.org
Subject: Re: [PATCH 6/6] i2c: designware: Move common probe code into i2c_dw_probe()
Date: Sat, 10 Oct 2015 08:57:26 +0100 [thread overview]
Message-ID: <20151010075725.GF1619@katana> (raw)
In-Reply-To: <1441031493-18938-7-git-send-email-jarkko.nikula@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 566 bytes --]
> - I2C Adapter name will be "i2c-designware". Previously adapter name was
> "Synopsys DesignWare I2C adapter" for platform and ACPI devices and
> "i2c-designware-pci" for PCI devices.
I have a small tendency to make it "Synopsys DesignWare I2C adapter" for
all cases. Not much, though.
> - Interrupt name too will be "i2c-designware". Previous it was platform
> device name, ACPI device name or "i2c-designware-pci".
The device name makes them easier to distinguish in case you have
multiple instantiations.
Rest of the series looks good to me, thanks!
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-10-10 7:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-31 14:31 [PATCH 0/6] i2c: designware: Code duplication removal and cleanups Jarkko Nikula
[not found] ` <1441031493-18938-1-git-send-email-jarkko.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2015-08-31 14:31 ` [PATCH 1/6] i2c: designware: Remove interrupt clearing from i2c_dw_pci_probe() Jarkko Nikula
2015-10-10 7:53 ` Wolfram Sang
2015-10-12 11:14 ` Jarkko Nikula
2015-10-15 12:01 ` Wolfram Sang
2015-08-31 14:31 ` [PATCH 2/6] i2c: designware: Disable interrupts before requesting PCI device interrupt Jarkko Nikula
2015-08-31 14:31 ` [PATCH 3/6] i2c: designware: Remove unused functions Jarkko Nikula
2015-08-31 14:31 ` [PATCH 4/6] i2c: designware: Make dw_readl() and dw_writel() static Jarkko Nikula
2015-08-31 14:31 ` [PATCH 5/6] i2c: designware: Rename platform driver probe and PM functions Jarkko Nikula
2015-08-31 14:31 ` [PATCH 6/6] i2c: designware: Move common probe code into i2c_dw_probe() Jarkko Nikula
2015-10-10 7:57 ` Wolfram Sang [this message]
2015-10-12 11:38 ` Jarkko Nikula
2015-10-12 13:55 ` [PATCH v2 " Jarkko Nikula
2015-10-20 16:32 ` Wolfram Sang
2015-10-21 14:10 ` Jarkko Nikula
2015-10-15 12:18 ` [PATCH 0/6] i2c: designware: Code duplication removal and cleanups Wolfram Sang
2015-10-15 13:01 ` Jarkko Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151010075725.GF1619@katana \
--to=wsa@the-dreams.de \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).