From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Ken Xue <Ken.Xue@amd.com>
Cc: baruch@tkos.co.il, SPG_Linux_Kernel@amd.com,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH 1/2] i2c: designware: register clkdev during acpi device configuration
Date: Tue, 20 Oct 2015 14:17:37 +0300 [thread overview]
Message-ID: <20151020111737.GF1526@lahna.fi.intel.com> (raw)
In-Reply-To: <1445323081.3380.25.camel@kxue-X58A-UD3R>
On Tue, Oct 20, 2015 at 02:38:01PM +0800, Ken Xue wrote:
> DW I2C driver tries to register a clk from id->driver_data as an
> alternative way besides intel lpss. But code doesn't register the
> clk to clkdev. So, devm_clk_get will fail during probe.
>
> The patch can fix this issue.
Since you now have drivers/acpi/acpi_apd.c for AMD ACPI stuff, can you
create the clock there just like we do for Intel stuff?
next prev parent reply other threads:[~2015-10-20 11:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-20 6:38 [PATCH 1/2] i2c: designware: register clkdev during acpi device configuration Ken Xue
2015-10-20 11:17 ` Mika Westerberg [this message]
2015-10-21 1:11 ` Ken Xue
2015-10-21 7:28 ` Mika Westerberg
2015-10-21 8:42 ` Ken Xue
2015-10-21 9:25 ` Mika Westerberg
2015-10-21 9:37 ` Ken Xue
2015-10-21 9:49 ` Mika Westerberg
2015-10-21 9:50 ` Ken Xue
2015-10-21 10:02 ` Mika Westerberg
2015-10-21 10:46 ` Mika Westerberg
2015-10-23 5:29 ` Ken Xue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151020111737.GF1526@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=Ken.Xue@amd.com \
--cc=SPG_Linux_Kernel@amd.com \
--cc=baruch@tkos.co.il \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).