From: Wolfram Sang <wsa@the-dreams.de>
To: Barry Song <21cnbao@gmail.com>
Cc: linux-i2c@vger.kernel.org, ldewangan@nvidia.com,
Donglin Peng <pengdonglin137@163.com>
Subject: Re: [PATCH] i2c: tegra: drop duplicated code for assigning algo
Date: Tue, 20 Oct 2015 17:40:46 +0200 [thread overview]
Message-ID: <20151020154046.GJ5379@katana> (raw)
In-Reply-To: <1441595335-31672-1-git-send-email-21cnbao@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 552 bytes --]
> @@ -825,7 +825,6 @@ static int tegra_i2c_probe(struct platform_device *pdev)
> i2c_dev->adapter.class = I2C_CLASS_DEPRECATED;
> strlcpy(i2c_dev->adapter.name, "Tegra I2C adapter",
> sizeof(i2c_dev->adapter.name));
> - i2c_dev->adapter.algo = &tegra_i2c_algo;
> i2c_dev->adapter.dev.parent = &pdev->dev;
> i2c_dev->adapter.nr = pdev->id;
> i2c_dev->adapter.dev.of_node = pdev->dev.of_node;
I think it would be more consistent to keep this one and move the quirk
assignment also down here; then all adapter assignments are in one
place.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-10-20 15:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-07 3:08 [PATCH] i2c: tegra: drop duplicated code for assigning algo Barry Song
2015-09-21 3:20 ` Barry Song
2015-10-20 15:40 ` Wolfram Sang [this message]
2015-10-23 20:51 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151020154046.GJ5379@katana \
--to=wsa@the-dreams.de \
--cc=21cnbao@gmail.com \
--cc=ldewangan@nvidia.com \
--cc=linux-i2c@vger.kernel.org \
--cc=pengdonglin137@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).