From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: Christian Fetzer <fetzer.ch@gmail.com>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-i2c@vger.kernel.org, tbrandonau@gmail.com,
eddi@depieri.net, galandilias@gmail.com
Subject: Re: [PATCH 0/4] Support multiplexed main SMBus interface on SB800
Date: Thu, 22 Oct 2015 14:43:35 +0300 [thread overview]
Message-ID: <20151022114335.GL1526@lahna.fi.intel.com> (raw)
In-Reply-To: <20151022110325.GA1572@katana>
On Thu, Oct 22, 2015 at 01:03:25PM +0200, Wolfram Sang wrote:
>
> > > > Please review and let me know required changes in order to get this upstream
> > > > finally.
> > > >
> > > > Eddi, Thomas, it would be great if you could verify the changes on your
> > > > machines.
> > >
> > > Yes, additional tests are always good for a patch series
> > >
> > > Asking the Intel guys for help, I have not much expierence with x86
> > > platforms... Mika, Jarkko, Andy any chance to help?
> >
> > Unfortunately I don't have hardware this old to test on :-/
>
> And visual review? (That's what I need to do mostly, too)
Sure.
I don't have a copy of these patches but I went ahead and looked them up
from archives. Christian can you Cc me on next iteration?
Mostly they look good to me. Few comments though.
Patch 2/4: should we remove adapter in reverse order?
Patch 3/4: some stylistic issues, like:
- ERROR label should not be in capital letters actually it is
not needed at all if you do unlock and return -EBUSY if
request_region() fails.
- Block comment style
In addition I'm not sure if requesting io region for each transfer is
good idea. Can't we just request it once for this driver and handle the
necessary serialization using the mutex?
next prev parent reply other threads:[~2015-10-22 11:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-25 11:05 [PATCH 0/4] Support multiplexed main SMBus interface on SB800 Christian Fetzer
[not found] ` <1440500705-2288-1-git-send-email-fetzer.ch-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-08-25 11:05 ` [PATCH 1/4] i2c-piix4: Optionally release smba in piix4_adap_remove Christian Fetzer
2015-08-25 11:05 ` [PATCH 2/4] i2c-piix4: Convert piix4_main_adapter to array Christian Fetzer
2015-08-25 11:05 ` [PATCH 3/4] i2c-piix4: Add support for multiplexed main adapter in SB800 Christian Fetzer
2015-08-25 11:05 ` [PATCH 4/4] i2c-piix4: Add adapter port name support for SB800 chipset Christian Fetzer
2015-10-10 7:45 ` [PATCH 0/4] Support multiplexed main SMBus interface on SB800 Wolfram Sang
2016-01-21 14:12 ` Jean Delvare
2015-10-20 15:19 ` Wolfram Sang
2015-10-22 8:27 ` Mika Westerberg
2015-10-22 11:03 ` Wolfram Sang
2015-10-22 11:43 ` Mika Westerberg [this message]
2015-11-01 16:38 ` fetzerch
2016-01-22 12:07 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151022114335.GL1526@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=eddi@depieri.net \
--cc=fetzer.ch@gmail.com \
--cc=galandilias@gmail.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=tbrandonau@gmail.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).