From: Wolfram Sang <wsa@the-dreams.de>
To: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: linux-i2c@vger.kernel.org, Tawfik Bayouk <tawfik@marvell.com>,
Nadav Haklai <nadavh@marvell.com>,
Lior Amsalem <alior@marvell.com>,
Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Gregory Clement <gregory.clement@free-electrons.com>,
Marcin Wojtas <mw@semihalf.com>, Hezi <hezi@marvell.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] i2c: mv64xxx: really allow I2C offloading
Date: Thu, 22 Oct 2015 14:49:05 +0200 [thread overview]
Message-ID: <20151022124905.GC1517@katana> (raw)
In-Reply-To: <1445351544-26062-1-git-send-email-thomas.petazzoni@free-electrons.com>
[-- Attachment #1: Type: text/plain, Size: 869 bytes --]
On Tue, Oct 20, 2015 at 04:32:24PM +0200, Thomas Petazzoni wrote:
> From: Hezi <hezi@marvell.com>
>
> Commit 00d8689b85a7 ("i2c: mv64xxx: rework offload support to fix
> several problems") completely reworked the offload support, but
> stupidly left a debugging-related "return false" at the beginning of
> the mv64xxx_i2c_can_offload() function. This has the unfortunate
> consequence that offloading is in fact never used, which wasn't really
> the intention.
>
> This commit fixes that problem by removing the stupid "return false".
>
> Fixes: 00d8689b85a7 ("i2c: mv64xxx: rework offload support to fix several problems")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Hezi <hezi@marvell.com>
> [Thomas: reworked commit log and title.]
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Applied to for-current, thanks!
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2015-10-22 12:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-20 14:32 [PATCH] i2c: mv64xxx: really allow I2C offloading Thomas Petazzoni
2015-10-20 16:22 ` Wolfram Sang
2015-10-20 16:56 ` Hezi Shahmoon
2015-10-20 17:29 ` Thomas Petazzoni
2015-10-21 6:18 ` Wolfram Sang
2015-10-22 12:49 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151022124905.GC1517@katana \
--to=wsa@the-dreams.de \
--cc=alior@marvell.com \
--cc=andrew@lunn.ch \
--cc=gregory.clement@free-electrons.com \
--cc=hezi@marvell.com \
--cc=jason@lakedaemon.net \
--cc=linux-i2c@vger.kernel.org \
--cc=mw@semihalf.com \
--cc=nadavh@marvell.com \
--cc=sebastian.hesselbarth@gmail.com \
--cc=stable@vger.kernel.org \
--cc=tawfik@marvell.com \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).