* [PATCH] i2c: mv64xxx: really allow I2C offloading
@ 2015-10-20 14:32 Thomas Petazzoni
2015-10-20 16:22 ` Wolfram Sang
2015-10-22 12:49 ` Wolfram Sang
0 siblings, 2 replies; 6+ messages in thread
From: Thomas Petazzoni @ 2015-10-20 14:32 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-i2c, Tawfik Bayouk, Nadav Haklai, Lior Amsalem,
Jason Cooper, Andrew Lunn, Sebastian Hesselbarth, Gregory Clement,
Marcin Wojtas, Hezi, stable, Thomas Petazzoni
From: Hezi <hezi@marvell.com>
Commit 00d8689b85a7 ("i2c: mv64xxx: rework offload support to fix
several problems") completely reworked the offload support, but
stupidly left a debugging-related "return false" at the beginning of
the mv64xxx_i2c_can_offload() function. This has the unfortunate
consequence that offloading is in fact never used, which wasn't really
the intention.
This commit fixes that problem by removing the stupid "return false".
Fixes: 00d8689b85a7 ("i2c: mv64xxx: rework offload support to fix several problems")
Cc: <stable@vger.kernel.org>
Signed-off-by: Hezi <hezi@marvell.com>
[Thomas: reworked commit log and title.]
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
Note: the original fix is from Hezi, but I rewrote the commit log,
which is why I authorized myself to treat my own work as being
"stupid". Which it really was.
---
drivers/i2c/busses/i2c-mv64xxx.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/i2c/busses/i2c-mv64xxx.c b/drivers/i2c/busses/i2c-mv64xxx.c
index 30059c1..5801227 100644
--- a/drivers/i2c/busses/i2c-mv64xxx.c
+++ b/drivers/i2c/busses/i2c-mv64xxx.c
@@ -669,8 +669,6 @@ mv64xxx_i2c_can_offload(struct mv64xxx_i2c_data *drv_data)
struct i2c_msg *msgs = drv_data->msgs;
int num = drv_data->num_msgs;
- return false;
-
if (!drv_data->offload_enabled)
return false;
--
2.6.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] i2c: mv64xxx: really allow I2C offloading
2015-10-20 14:32 [PATCH] i2c: mv64xxx: really allow I2C offloading Thomas Petazzoni
@ 2015-10-20 16:22 ` Wolfram Sang
2015-10-20 16:56 ` Hezi Shahmoon
2015-10-22 12:49 ` Wolfram Sang
1 sibling, 1 reply; 6+ messages in thread
From: Wolfram Sang @ 2015-10-20 16:22 UTC (permalink / raw)
To: Thomas Petazzoni
Cc: linux-i2c, Tawfik Bayouk, Nadav Haklai, Lior Amsalem,
Jason Cooper, Andrew Lunn, Sebastian Hesselbarth, Gregory Clement,
Marcin Wojtas, Hezi, stable
[-- Attachment #1: Type: text/plain, Size: 1610 bytes --]
On Tue, Oct 20, 2015 at 04:32:24PM +0200, Thomas Petazzoni wrote:
> From: Hezi <hezi@marvell.com>
Is "Hezi" the full name?
>
> Commit 00d8689b85a7 ("i2c: mv64xxx: rework offload support to fix
> several problems") completely reworked the offload support, but
> stupidly left a debugging-related "return false" at the beginning of
> the mv64xxx_i2c_can_offload() function. This has the unfortunate
> consequence that offloading is in fact never used, which wasn't really
> the intention.
>
> This commit fixes that problem by removing the stupid "return false".
>
> Fixes: 00d8689b85a7 ("i2c: mv64xxx: rework offload support to fix several problems")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Hezi <hezi@marvell.com>
> [Thomas: reworked commit log and title.]
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
> Note: the original fix is from Hezi, but I rewrote the commit log,
> which is why I authorized myself to treat my own work as being
> "stupid". Which it really was.
:)
> ---
> drivers/i2c/busses/i2c-mv64xxx.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-mv64xxx.c b/drivers/i2c/busses/i2c-mv64xxx.c
> index 30059c1..5801227 100644
> --- a/drivers/i2c/busses/i2c-mv64xxx.c
> +++ b/drivers/i2c/busses/i2c-mv64xxx.c
> @@ -669,8 +669,6 @@ mv64xxx_i2c_can_offload(struct mv64xxx_i2c_data *drv_data)
> struct i2c_msg *msgs = drv_data->msgs;
> int num = drv_data->num_msgs;
>
> - return false;
> -
> if (!drv_data->offload_enabled)
> return false;
>
> --
> 2.6.2
>
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* RE: [PATCH] i2c: mv64xxx: really allow I2C offloading
2015-10-20 16:22 ` Wolfram Sang
@ 2015-10-20 16:56 ` Hezi Shahmoon
2015-10-20 17:29 ` Thomas Petazzoni
0 siblings, 1 reply; 6+ messages in thread
From: Hezi Shahmoon @ 2015-10-20 16:56 UTC (permalink / raw)
To: Wolfram Sang, Thomas Petazzoni
Cc: linux-i2c@vger.kernel.org, Tawfik Bayouk, Nadav Haklai,
Lior Amsalem, Jason Cooper, Andrew Lunn, Sebastian Hesselbarth,
Gregory Clement, Marcin Wojtas, stable@vger.kernel.org
Hi.
It is:
Hezi Shahmoon
Email:
hezi@marvell.com
I will fix this for future commits.
Thanks,
Hezi.
-----Original Message-----
From: Wolfram Sang [mailto:wsa@the-dreams.de]
Sent: Tuesday, October 20, 2015 7:22 PM
To: Thomas Petazzoni
Cc: linux-i2c@vger.kernel.org; Tawfik Bayouk; Nadav Haklai; Lior Amsalem; Jason Cooper; Andrew Lunn; Sebastian Hesselbarth; Gregory Clement; Marcin Wojtas; Hezi Shahmoon; stable@vger.kernel.org
Subject: Re: [PATCH] i2c: mv64xxx: really allow I2C offloading
On Tue, Oct 20, 2015 at 04:32:24PM +0200, Thomas Petazzoni wrote:
> From: Hezi <hezi@marvell.com>
Is "Hezi" the full name?
>
> Commit 00d8689b85a7 ("i2c: mv64xxx: rework offload support to fix
> several problems") completely reworked the offload support, but
> stupidly left a debugging-related "return false" at the beginning of
> the mv64xxx_i2c_can_offload() function. This has the unfortunate
> consequence that offloading is in fact never used, which wasn't really
> the intention.
>
> This commit fixes that problem by removing the stupid "return false".
>
> Fixes: 00d8689b85a7 ("i2c: mv64xxx: rework offload support to fix
> several problems")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Hezi <hezi@marvell.com>
> [Thomas: reworked commit log and title.]
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
> Note: the original fix is from Hezi, but I rewrote the commit log,
> which is why I authorized myself to treat my own work as being
> "stupid". Which it really was.
:)
> ---
> drivers/i2c/busses/i2c-mv64xxx.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-mv64xxx.c
> b/drivers/i2c/busses/i2c-mv64xxx.c
> index 30059c1..5801227 100644
> --- a/drivers/i2c/busses/i2c-mv64xxx.c
> +++ b/drivers/i2c/busses/i2c-mv64xxx.c
> @@ -669,8 +669,6 @@ mv64xxx_i2c_can_offload(struct mv64xxx_i2c_data *drv_data)
> struct i2c_msg *msgs = drv_data->msgs;
> int num = drv_data->num_msgs;
>
> - return false;
> -
> if (!drv_data->offload_enabled)
> return false;
>
> --
> 2.6.2
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] i2c: mv64xxx: really allow I2C offloading
2015-10-20 16:56 ` Hezi Shahmoon
@ 2015-10-20 17:29 ` Thomas Petazzoni
2015-10-21 6:18 ` Wolfram Sang
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Petazzoni @ 2015-10-20 17:29 UTC (permalink / raw)
To: Hezi Shahmoon
Cc: Wolfram Sang, linux-i2c@vger.kernel.org, Tawfik Bayouk,
Nadav Haklai, Lior Amsalem, Jason Cooper, Andrew Lunn,
Sebastian Hesselbarth, Gregory Clement, Marcin Wojtas,
stable@vger.kernel.org
Hello,
On Tue, 20 Oct 2015 16:56:21 +0000, Hezi Shahmoon wrote:
> Hi.
>
> It is:
> Hezi Shahmoon
>
> Email:
> hezi@marvell.com
Thanks Hezi.
Wolfram, do you want me to send a v2 with Hezi's full name or will you
fix that up when applying the patch ?
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] i2c: mv64xxx: really allow I2C offloading
2015-10-20 17:29 ` Thomas Petazzoni
@ 2015-10-21 6:18 ` Wolfram Sang
0 siblings, 0 replies; 6+ messages in thread
From: Wolfram Sang @ 2015-10-21 6:18 UTC (permalink / raw)
To: Thomas Petazzoni
Cc: Hezi Shahmoon, linux-i2c@vger.kernel.org, Tawfik Bayouk,
Nadav Haklai, Lior Amsalem, Jason Cooper, Andrew Lunn,
Sebastian Hesselbarth, Gregory Clement, Marcin Wojtas,
stable@vger.kernel.org
[-- Attachment #1: Type: text/plain, Size: 125 bytes --]
> Wolfram, do you want me to send a v2 with Hezi's full name or will you
> fix that up when applying the patch ?
I'll fix.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] i2c: mv64xxx: really allow I2C offloading
2015-10-20 14:32 [PATCH] i2c: mv64xxx: really allow I2C offloading Thomas Petazzoni
2015-10-20 16:22 ` Wolfram Sang
@ 2015-10-22 12:49 ` Wolfram Sang
1 sibling, 0 replies; 6+ messages in thread
From: Wolfram Sang @ 2015-10-22 12:49 UTC (permalink / raw)
To: Thomas Petazzoni
Cc: linux-i2c, Tawfik Bayouk, Nadav Haklai, Lior Amsalem,
Jason Cooper, Andrew Lunn, Sebastian Hesselbarth, Gregory Clement,
Marcin Wojtas, Hezi, stable
[-- Attachment #1: Type: text/plain, Size: 869 bytes --]
On Tue, Oct 20, 2015 at 04:32:24PM +0200, Thomas Petazzoni wrote:
> From: Hezi <hezi@marvell.com>
>
> Commit 00d8689b85a7 ("i2c: mv64xxx: rework offload support to fix
> several problems") completely reworked the offload support, but
> stupidly left a debugging-related "return false" at the beginning of
> the mv64xxx_i2c_can_offload() function. This has the unfortunate
> consequence that offloading is in fact never used, which wasn't really
> the intention.
>
> This commit fixes that problem by removing the stupid "return false".
>
> Fixes: 00d8689b85a7 ("i2c: mv64xxx: rework offload support to fix several problems")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Hezi <hezi@marvell.com>
> [Thomas: reworked commit log and title.]
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Applied to for-current, thanks!
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-10-22 12:49 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-20 14:32 [PATCH] i2c: mv64xxx: really allow I2C offloading Thomas Petazzoni
2015-10-20 16:22 ` Wolfram Sang
2015-10-20 16:56 ` Hezi Shahmoon
2015-10-20 17:29 ` Thomas Petazzoni
2015-10-21 6:18 ` Wolfram Sang
2015-10-22 12:49 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).