Re: [PATCH] i2c-dev: Fix typo in ioctl name reference

[Wolfram Sang <wsa@the-dreams.de>]

[-- Attachment #1: Type: text/plain, Size: 1109 bytes --]

> > > -#define  I2C_RDRW_IOCTL_MAX_MSGS	42
> > > +#define  I2C_RDWR_IOCTL_MAX_MSGS	42
> > > +/* Originally defined with a typo, keep if for now for compatibility */
> > 
> > I would drop the 'for now' and keep it forever. A define doesn't hurt
> > and if it increases backwards compatibility, why not? I will also do
> > s/if/it/. No need to resend.
> 
> Sorry for the typo and thanks for catching it. "for now" or not is up
> to you, my idea was that it probably wasn't used in user-space yet so
> getting rid of it shouldn't hurt, while keeping it would encourage
> people to use the wrong one instead of the good one. So on second
> thought a better strategy may be to NOT keep the compatibility in the
> first place.

I really don't want to break userspace. And since this #define is in the
uapi headers, I rather be safe than sorry. There might be programs using
it we don't know about.

So:

Applied to for-next, thanks!

> can be reported to the user just the same. IMHO I2C_RDWR_IOCTL_MAX_MSGS
> should not have been made visible from user-space in the first place.

Yes.


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]