From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean Delvare Subject: Re: [PATCH] i2c: i801: Add support for Intel Broxton Date: Sun, 25 Oct 2015 11:50:05 +0100 Message-ID: <20151025115005.62c834f0@endymion.delvare> References: <1445523418-5166-1-git-send-email-jarkko.nikula@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de ([195.135.220.15]:40840 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752713AbbJYKuI (ORCPT ); Sun, 25 Oct 2015 06:50:08 -0400 In-Reply-To: <1445523418-5166-1-git-send-email-jarkko.nikula@linux.intel.com> Sender: linux-i2c-owner@vger.kernel.org List-Id: linux-i2c@vger.kernel.org To: Jarkko Nikula Cc: linux-i2c@vger.kernel.org, Jean Delvare , Wolfram Sang , Mika Westerberg Hi Jarkko, On Thu, 22 Oct 2015 17:16:58 +0300, Jarkko Nikula wrote: > This patch adds the SMBUS PCI ID of Intel Broxton. > > Signed-off-by: Jarkko Nikula > --- > This goes on top of Mika's "[PATCH] i2c: i801: Add support for Intel DNV": > http://marc.info/?l=linux-i2c&m=144474010421111&w=2 > --- > drivers/i2c/busses/i2c-i801.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c > index 47c2ddf76264..d8219bc2ac4e 100644 > --- a/drivers/i2c/busses/i2c-i801.c > +++ b/drivers/i2c/busses/i2c-i801.c > @@ -61,6 +61,7 @@ > * Sunrise Point-H (PCH) 0xa123 32 hard yes yes yes > * Sunrise Point-LP (PCH) 0x9d23 32 hard yes yes yes > * DNV (SOC) 0x19df 32 hard yes yes yes > + * Broxton (SOC) 0x5ad4 32 hard yes yes yes > * > * Features supported by this driver: > * Software PEC no > @@ -204,6 +205,7 @@ > #define PCI_DEVICE_ID_INTEL_SUNRISEPOINT_H_SMBUS 0xa123 > #define PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_SMBUS 0x9d23 > #define PCI_DEVICE_ID_INTEL_DNV_SMBUS 0x19df > +#define PCI_DEVICE_ID_INTEL_BROXTON_SMBUS 0x5ad4 Can you please get this added to pci.ids? http://pci-ids.ucw.cz/read/PC/8086 > struct i801_mux_config { > char *gpio_chip; > @@ -866,6 +868,7 @@ static const struct pci_device_id i801_ids[] = { > { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_SUNRISEPOINT_H_SMBUS) }, > { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_SMBUS) }, > { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_DNV_SMBUS) }, > + { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_BROXTON_SMBUS) }, > { 0, } > }; > Does this one not have FEATURE_TCO as DNV does? If it does, you'll need to add a line for it in the switch block in i801_probe(). Please also update Documentation/i2c/busses/i2c-i801 and drivers/i2c/busses/Kconfig. Thanks, -- Jean Delvare SUSE L3 Support