* [PATCH] i2c: i801: Add support for Intel DNV
@ 2015-10-13 12:41 Mika Westerberg
2015-10-23 20:11 ` Wolfram Sang
2015-10-25 10:45 ` Jean Delvare
0 siblings, 2 replies; 5+ messages in thread
From: Mika Westerberg @ 2015-10-13 12:41 UTC (permalink / raw)
To: Jean Delvare, Wolfram Sang; +Cc: linux-i2c, Mika Westerberg, Jarkko Nikula
Intel DNV SoC has the same legacy SMBus host controller than Intel
Sunrisepoint PCH. It also has same iTCO watchdog on the bus.
Add DNV PCI ID to the list of supported devices.
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
---
drivers/i2c/busses/i2c-i801.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c
index eaef9bc9d88c..47c2ddf76264 100644
--- a/drivers/i2c/busses/i2c-i801.c
+++ b/drivers/i2c/busses/i2c-i801.c
@@ -60,6 +60,7 @@
* BayTrail (SOC) 0x0f12 32 hard yes yes yes
* Sunrise Point-H (PCH) 0xa123 32 hard yes yes yes
* Sunrise Point-LP (PCH) 0x9d23 32 hard yes yes yes
+ * DNV (SOC) 0x19df 32 hard yes yes yes
*
* Features supported by this driver:
* Software PEC no
@@ -202,6 +203,7 @@
#define PCI_DEVICE_ID_INTEL_WILDCATPOINT_LP_SMBUS 0x9ca2
#define PCI_DEVICE_ID_INTEL_SUNRISEPOINT_H_SMBUS 0xa123
#define PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_SMBUS 0x9d23
+#define PCI_DEVICE_ID_INTEL_DNV_SMBUS 0x19df
struct i801_mux_config {
char *gpio_chip;
@@ -863,6 +865,7 @@ static const struct pci_device_id i801_ids[] = {
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_BRASWELL_SMBUS) },
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_SUNRISEPOINT_H_SMBUS) },
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_SMBUS) },
+ { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_DNV_SMBUS) },
{ 0, }
};
@@ -1256,6 +1259,7 @@ static int i801_probe(struct pci_dev *dev, const struct pci_device_id *id)
switch (dev->device) {
case PCI_DEVICE_ID_INTEL_SUNRISEPOINT_H_SMBUS:
case PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_SMBUS:
+ case PCI_DEVICE_ID_INTEL_DNV_SMBUS:
priv->features |= FEATURE_I2C_BLOCK_READ;
priv->features |= FEATURE_IRQ;
priv->features |= FEATURE_SMBUS_PEC;
--
2.5.3
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] i2c: i801: Add support for Intel DNV
2015-10-13 12:41 [PATCH] i2c: i801: Add support for Intel DNV Mika Westerberg
@ 2015-10-23 20:11 ` Wolfram Sang
2015-10-25 10:45 ` Jean Delvare
1 sibling, 0 replies; 5+ messages in thread
From: Wolfram Sang @ 2015-10-23 20:11 UTC (permalink / raw)
To: Mika Westerberg; +Cc: Jean Delvare, linux-i2c, Jarkko Nikula
[-- Attachment #1: Type: text/plain, Size: 362 bytes --]
On Tue, Oct 13, 2015 at 03:41:39PM +0300, Mika Westerberg wrote:
> Intel DNV SoC has the same legacy SMBus host controller than Intel
> Sunrisepoint PCH. It also has same iTCO watchdog on the bus.
>
> Add DNV PCI ID to the list of supported devices.
>
> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Applied to for-next, thanks!
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] i2c: i801: Add support for Intel DNV
2015-10-13 12:41 [PATCH] i2c: i801: Add support for Intel DNV Mika Westerberg
2015-10-23 20:11 ` Wolfram Sang
@ 2015-10-25 10:45 ` Jean Delvare
2015-10-26 9:24 ` Mika Westerberg
1 sibling, 1 reply; 5+ messages in thread
From: Jean Delvare @ 2015-10-25 10:45 UTC (permalink / raw)
To: Mika Westerberg; +Cc: Jean Delvare, Wolfram Sang, linux-i2c, Jarkko Nikula
Hi Mika,
On Tue, 13 Oct 2015 15:41:39 +0300, Mika Westerberg wrote:
> Intel DNV SoC has the same legacy SMBus host controller than Intel
> Sunrisepoint PCH. It also has same iTCO watchdog on the bus.
>
> Add DNV PCI ID to the list of supported devices.
>
> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> ---
> drivers/i2c/busses/i2c-i801.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c
> index eaef9bc9d88c..47c2ddf76264 100644
> --- a/drivers/i2c/busses/i2c-i801.c
> +++ b/drivers/i2c/busses/i2c-i801.c
> @@ -60,6 +60,7 @@
> * BayTrail (SOC) 0x0f12 32 hard yes yes yes
> * Sunrise Point-H (PCH) 0xa123 32 hard yes yes yes
> * Sunrise Point-LP (PCH) 0x9d23 32 hard yes yes yes
> + * DNV (SOC) 0x19df 32 hard yes yes yes
> *
> * Features supported by this driver:
> * Software PEC no
> @@ -202,6 +203,7 @@
> #define PCI_DEVICE_ID_INTEL_WILDCATPOINT_LP_SMBUS 0x9ca2
> #define PCI_DEVICE_ID_INTEL_SUNRISEPOINT_H_SMBUS 0xa123
> #define PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_SMBUS 0x9d23
> +#define PCI_DEVICE_ID_INTEL_DNV_SMBUS 0x19df
Can you please get this added to pci.ids?
http://pci-ids.ucw.cz/read/PC/8086
>
> struct i801_mux_config {
> char *gpio_chip;
> @@ -863,6 +865,7 @@ static const struct pci_device_id i801_ids[] = {
> { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_BRASWELL_SMBUS) },
> { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_SUNRISEPOINT_H_SMBUS) },
> { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_SMBUS) },
> + { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_DNV_SMBUS) },
> { 0, }
> };
>
> @@ -1256,6 +1259,7 @@ static int i801_probe(struct pci_dev *dev, const struct pci_device_id *id)
> switch (dev->device) {
> case PCI_DEVICE_ID_INTEL_SUNRISEPOINT_H_SMBUS:
> case PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_SMBUS:
> + case PCI_DEVICE_ID_INTEL_DNV_SMBUS:
> priv->features |= FEATURE_I2C_BLOCK_READ;
> priv->features |= FEATURE_IRQ;
> priv->features |= FEATURE_SMBUS_PEC;
Looks good, but please also update Documentation/i2c/busses/i2c-i801
and drivers/i2c/busses/Kconfig.
--
Jean Delvare
SUSE L3 Support
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] i2c: i801: Add support for Intel DNV
2015-10-25 10:45 ` Jean Delvare
@ 2015-10-26 9:24 ` Mika Westerberg
2015-10-26 10:49 ` Wolfram Sang
0 siblings, 1 reply; 5+ messages in thread
From: Mika Westerberg @ 2015-10-26 9:24 UTC (permalink / raw)
To: Jean Delvare; +Cc: Jean Delvare, Wolfram Sang, linux-i2c, Jarkko Nikula
On Sun, Oct 25, 2015 at 11:45:18AM +0100, Jean Delvare wrote:
> Hi Mika,
>
> On Tue, 13 Oct 2015 15:41:39 +0300, Mika Westerberg wrote:
> > Intel DNV SoC has the same legacy SMBus host controller than Intel
> > Sunrisepoint PCH. It also has same iTCO watchdog on the bus.
> >
> > Add DNV PCI ID to the list of supported devices.
> >
> > Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> > ---
> > drivers/i2c/busses/i2c-i801.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c
> > index eaef9bc9d88c..47c2ddf76264 100644
> > --- a/drivers/i2c/busses/i2c-i801.c
> > +++ b/drivers/i2c/busses/i2c-i801.c
> > @@ -60,6 +60,7 @@
> > * BayTrail (SOC) 0x0f12 32 hard yes yes yes
> > * Sunrise Point-H (PCH) 0xa123 32 hard yes yes yes
> > * Sunrise Point-LP (PCH) 0x9d23 32 hard yes yes yes
> > + * DNV (SOC) 0x19df 32 hard yes yes yes
> > *
> > * Features supported by this driver:
> > * Software PEC no
> > @@ -202,6 +203,7 @@
> > #define PCI_DEVICE_ID_INTEL_WILDCATPOINT_LP_SMBUS 0x9ca2
> > #define PCI_DEVICE_ID_INTEL_SUNRISEPOINT_H_SMBUS 0xa123
> > #define PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_SMBUS 0x9d23
> > +#define PCI_DEVICE_ID_INTEL_DNV_SMBUS 0x19df
>
> Can you please get this added to pci.ids?
>
> http://pci-ids.ucw.cz/read/PC/8086
Sure.
> >
> > struct i801_mux_config {
> > char *gpio_chip;
> > @@ -863,6 +865,7 @@ static const struct pci_device_id i801_ids[] = {
> > { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_BRASWELL_SMBUS) },
> > { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_SUNRISEPOINT_H_SMBUS) },
> > { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_SMBUS) },
> > + { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_DNV_SMBUS) },
> > { 0, }
> > };
> >
> > @@ -1256,6 +1259,7 @@ static int i801_probe(struct pci_dev *dev, const struct pci_device_id *id)
> > switch (dev->device) {
> > case PCI_DEVICE_ID_INTEL_SUNRISEPOINT_H_SMBUS:
> > case PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_SMBUS:
> > + case PCI_DEVICE_ID_INTEL_DNV_SMBUS:
> > priv->features |= FEATURE_I2C_BLOCK_READ;
> > priv->features |= FEATURE_IRQ;
> > priv->features |= FEATURE_SMBUS_PEC;
>
> Looks good, but please also update Documentation/i2c/busses/i2c-i801
> and drivers/i2c/busses/Kconfig.
Will do thanks.
Wolfram, do you want followup patch on top of this or do you prefer
updated patch?
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-10-26 10:49 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-13 12:41 [PATCH] i2c: i801: Add support for Intel DNV Mika Westerberg
2015-10-23 20:11 ` Wolfram Sang
2015-10-25 10:45 ` Jean Delvare
2015-10-26 9:24 ` Mika Westerberg
2015-10-26 10:49 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).