[PATCH] i2c: Enable Cadence driver for ARM64

[PATCH] i2c: Enable Cadence driver for ARM64

[Michal Simek]

This IP is available on Xilinx ZynqMP.

Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---

 drivers/i2c/busses/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
index 08b86178e8fb..d54c0e6d65d8 100644
--- a/drivers/i2c/busses/Kconfig
+++ b/drivers/i2c/busses/Kconfig
@@ -422,7 +422,7 @@ config I2C_BLACKFIN_TWI_CLK_KHZ
 
 config I2C_CADENCE
 	tristate "Cadence I2C Controller"
-	depends on ARCH_ZYNQ
+	depends on ARCH_ZYNQ || ARM64
 	help
 	  Say yes here to select Cadence I2C Host Controller. This controller is
 	  e.g. used by Xilinx Zynq.
-- 
2.5.0

Re: [PATCH] i2c: Enable Cadence driver for ARM64

[Lee Jones]

Regarding your address list -- it's too big.  Most of your addressees
don't care about this patch.  Please be more selective when sending
patches to people, most of us have enough (relevant) mail as it is.

> This IP is available on Xilinx ZynqMP.
> 
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
> 
>  drivers/i2c/busses/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
> index 08b86178e8fb..d54c0e6d65d8 100644
> --- a/drivers/i2c/busses/Kconfig
> +++ b/drivers/i2c/busses/Kconfig
> @@ -422,7 +422,7 @@ config I2C_BLACKFIN_TWI_CLK_KHZ
>  
>  config I2C_CADENCE
>  	tristate "Cadence I2C Controller"
> -	depends on ARCH_ZYNQ
> +	depends on ARCH_ZYNQ || ARM64
>  	help
>  	  Say yes here to select Cadence I2C Host Controller. This controller is
>  	  e.g. used by Xilinx Zynq.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH] i2c: Enable Cadence driver for ARM64

[Michal Simek]

Hi,

On 10/26/2015 03:32 PM, Lee Jones wrote:
> Regarding your address list -- it's too big.  Most of your addressees
> don't care about this patch.  Please be more selective when sending
> patches to people, most of us have enough (relevant) mail as it is.

This is just what get_maintainer.pl is returning you. And I do use
patman (uboot tools) for ages and none has any problem with it. That's
why I am curious why you have the problem with it.

Thanks,
Michal

Re: [PATCH] i2c: Enable Cadence driver for ARM64

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 408 bytes --]

On Mon, Oct 26, 2015 at 02:32:36PM +0000, Lee Jones wrote:
> Regarding your address list -- it's too big.  Most of your addressees
> don't care about this patch.  Please be more selective when sending
> patches to people, most of us have enough (relevant) mail as it is.

Probably more effective than to write every user of get_maintainer.pl:
Patch it to not use git history by default and win the fight ;)


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH] i2c: Enable Cadence driver for ARM64

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 200 bytes --]

On Mon, Oct 26, 2015 at 03:09:53PM +0100, Michal Simek wrote:
> This IP is available on Xilinx ZynqMP.
> 
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>

Applied to for-next, thanks!


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH] i2c: Enable Cadence driver for ARM64

[Lee Jones]

On Mon, 26 Oct 2015, Michal Simek wrote:
> On 10/26/2015 03:32 PM, Lee Jones wrote:
> > Regarding your address list -- it's too big.  Most of your addressees
> > don't care about this patch.  Please be more selective when sending
> > patches to people, most of us have enough (relevant) mail as it is.
> 
> This is just what get_maintainer.pl is returning you. And I do use
> patman (uboot tools) for ages and none has any problem with it. That's
> why I am curious why you have the problem with it.

git_maintainer.pl is best used with the --no-git-fallback flag.  If
you don't it tells you about everyone who adapted, looked at, opened,
and/or breathed on the file.  The only people that are likely to care
about your change is either the original author of the specific hunk
you are changing and the Maintainers/Supporters.  To everyone else
these emails are spam.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH] i2c: Enable Cadence driver for ARM64

[Lee Jones]

On Mon, 26 Oct 2015, Wolfram Sang wrote:
> On Mon, Oct 26, 2015 at 02:32:36PM +0000, Lee Jones wrote:
> > Regarding your address list -- it's too big.  Most of your addressees
> > don't care about this patch.  Please be more selective when sending
> > patches to people, most of us have enough (relevant) mail as it is.
> 
> Probably more effective than to write every user of get_maintainer.pl:
> Patch it to not use git history by default and win the fight ;)

Geert wrote to Joe today.  Let's see if he can improve things.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH] i2c: Enable Cadence driver for ARM64

[Javier Martinez Canillas]

Hello,

On 10/27/2015 12:00 AM, Lee Jones wrote:
> On Mon, 26 Oct 2015, Wolfram Sang wrote:
>> On Mon, Oct 26, 2015 at 02:32:36PM +0000, Lee Jones wrote:
>>> Regarding your address list -- it's too big.  Most of your addressees
>>> don't care about this patch.  Please be more selective when sending
>>> patches to people, most of us have enough (relevant) mail as it is.
>>
>> Probably more effective than to write every user of get_maintainer.pl:
>> Patch it to not use git history by default and win the fight ;)
>

Agreed, coincidentally I was telling people today that get_maintainers.pl
only provides a suggestion and that it should not be followed blindly.

> Geert wrote to Joe today.  Let's see if he can improve things.
> 

What about something like the following patch until Joe writes a more
smarter git fallback version?

>From d6dc34810d24f33afb3c158d519966c1b6167a2f Mon Sep 17 00:00:00 2001
From: Javier Martinez Canillas <javier@osg.samsung.com>
Date: Mon, 26 Oct 2015 23:46:52 +0900
Subject: [RFC PATCH] get_maintainer: Don't fallback to git by default

The get_maintainer.pl script could be used to get a list of people that
has to be in the copy list when posting patches for a given file but it
defaults to git fallback so the list returned isn't really relevant and
submitters are posting patches to random developers that just happened
to touch that file in the past.

Disable git fallback so get_maintainer.pl only returns the information
that is in MAINTAINERS by default.

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
 scripts/get_maintainer.pl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
index 98bae869f6d0..b52ae26270e8 100755
--- a/scripts/get_maintainer.pl
+++ b/scripts/get_maintainer.pl
@@ -29,7 +29,7 @@ my $email_git = 0;
 my $email_git_all_signature_types = 0;
 my $email_git_blame = 0;
 my $email_git_blame_signatures = 1;
-my $email_git_fallback = 1;
+my $email_git_fallback = 0;
 my $email_git_min_signatures = 1;
 my $email_git_max_maintainers = 5;
 my $email_git_min_percent = 5;
-- 
2.4.3

Re: [PATCH] i2c: Enable Cadence driver for ARM64

[Lee Jones]

On Tue, 27 Oct 2015, Javier Martinez Canillas wrote:

> Hello,
> 
> On 10/27/2015 12:00 AM, Lee Jones wrote:
> > On Mon, 26 Oct 2015, Wolfram Sang wrote:
> >> On Mon, Oct 26, 2015 at 02:32:36PM +0000, Lee Jones wrote:
> >>> Regarding your address list -- it's too big.  Most of your addressees
> >>> don't care about this patch.  Please be more selective when sending
> >>> patches to people, most of us have enough (relevant) mail as it is.
> >>
> >> Probably more effective than to write every user of get_maintainer.pl:
> >> Patch it to not use git history by default and win the fight ;)
> >
> 
> Agreed, coincidentally I was telling people today that get_maintainers.pl
> only provides a suggestion and that it should not be followed blindly.
> 
> > Geert wrote to Joe today.  Let's see if he can improve things.
> > 
> 
> What about something like the following patch until Joe writes a more
> smarter git fallback version?
> 
> From d6dc34810d24f33afb3c158d519966c1b6167a2f Mon Sep 17 00:00:00 2001
> From: Javier Martinez Canillas <javier@osg.samsung.com>
> Date: Mon, 26 Oct 2015 23:46:52 +0900
> Subject: [RFC PATCH] get_maintainer: Don't fallback to git by default
> 
> The get_maintainer.pl script could be used to get a list of people that
> has to be in the copy list when posting patches for a given file but it
> defaults to git fallback so the list returned isn't really relevant and
> submitters are posting patches to random developers that just happened
> to touch that file in the past.
> 
> Disable git fallback so get_maintainer.pl only returns the information
> that is in MAINTAINERS by default.
> 
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> ---
>  scripts/get_maintainer.pl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Works for me.  Although you should have used get_maintainer.pl and
CC'ed Joe. ;)

I never did this before -- it was both odd and fun:

  $ ./scripts/get_maintainer.pl -f scripts/get_maintainer.pl 
  Joe Perches <joe@perches.com> (maintainer:GET_MAINTAINER SCRIPT)

> diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
> index 98bae869f6d0..b52ae26270e8 100755
> --- a/scripts/get_maintainer.pl
> +++ b/scripts/get_maintainer.pl
> @@ -29,7 +29,7 @@ my $email_git = 0;
>  my $email_git_all_signature_types = 0;
>  my $email_git_blame = 0;
>  my $email_git_blame_signatures = 1;
> -my $email_git_fallback = 1;
> +my $email_git_fallback = 0;
>  my $email_git_min_signatures = 1;
>  my $email_git_max_maintainers = 5;
>  my $email_git_min_percent = 5;

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH] i2c: Enable Cadence driver for ARM64

[Javier Martinez Canillas]

Hello Lee,

On 10/27/2015 01:45 AM, Lee Jones wrote:
> On Tue, 27 Oct 2015, Javier Martinez Canillas wrote:
> 
>> Hello,
>>
>> On 10/27/2015 12:00 AM, Lee Jones wrote:
>>> On Mon, 26 Oct 2015, Wolfram Sang wrote:
>>>> On Mon, Oct 26, 2015 at 02:32:36PM +0000, Lee Jones wrote:
>>>>> Regarding your address list -- it's too big.  Most of your addressees
>>>>> don't care about this patch.  Please be more selective when sending
>>>>> patches to people, most of us have enough (relevant) mail as it is.
>>>>
>>>> Probably more effective than to write every user of get_maintainer.pl:
>>>> Patch it to not use git history by default and win the fight ;)
>>>
>>
>> Agreed, coincidentally I was telling people today that get_maintainers.pl
>> only provides a suggestion and that it should not be followed blindly.
>>
>>> Geert wrote to Joe today.  Let's see if he can improve things.
>>>
>>
>> What about something like the following patch until Joe writes a more
>> smarter git fallback version?
>>
>> From d6dc34810d24f33afb3c158d519966c1b6167a2f Mon Sep 17 00:00:00 2001
>> From: Javier Martinez Canillas <javier@osg.samsung.com>
>> Date: Mon, 26 Oct 2015 23:46:52 +0900
>> Subject: [RFC PATCH] get_maintainer: Don't fallback to git by default
>>
>> The get_maintainer.pl script could be used to get a list of people that
>> has to be in the copy list when posting patches for a given file but it
>> defaults to git fallback so the list returned isn't really relevant and
>> submitters are posting patches to random developers that just happened
>> to touch that file in the past.
>>
>> Disable git fallback so get_maintainer.pl only returns the information
>> that is in MAINTAINERS by default.
>>
>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>> ---
>>  scripts/get_maintainer.pl | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Works for me.  Although you should have used get_maintainer.pl and
> CC'ed Joe. ;)
>

hehe, yes. I first wanted to share with Wolfram and you to see if
that is what you were thinking about and that is why I didn't add
Joe and marked the patch as RFC.

I posted it as a proper patch now and also added a Suggested-by
tag from Wolfram.
 
> I never did this before -- it was both odd and fun:
> 
>   $ ./scripts/get_maintainer.pl -f scripts/get_maintainer.pl 
>   Joe Perches <joe@perches.com> (maintainer:GET_MAINTAINER SCRIPT)
>

Fun indeed.

[0]: https://patchwork.kernel.org/patch/7492371/

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America