linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] i2c: pnx: remove superfluous assignment
@ 2015-10-25 15:20 Wolfram Sang
  2015-10-30 11:36 ` Wolfram Sang
  0 siblings, 1 reply; 2+ messages in thread
From: Wolfram Sang @ 2015-10-25 15:20 UTC (permalink / raw)
  To: linux-i2c
  Cc: Wolfram Sang, Vladimir Zapolskiy, Muhammad Falak R Wani,
	Vitaly Wool

smatch rightfully says:

drivers/i2c/busses/i2c-pnx.c:499 i2c_pnx_xfer warn: unused return: stat = ioread32()

Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
Cc: Vladimir Zapolskiy <vz@mleia.com>
Cc: Muhammad Falak R Wani <falakreyaz@gmail.com>
Cc: Vitaly Wool <vitalywool@gmail.com>
---
 drivers/i2c/busses/i2c-pnx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/i2c/busses/i2c-pnx.c b/drivers/i2c/busses/i2c-pnx.c
index cdbf6320cb909e..1b8bf368be0c15 100644
--- a/drivers/i2c/busses/i2c-pnx.c
+++ b/drivers/i2c/busses/i2c-pnx.c
@@ -496,7 +496,7 @@ i2c_pnx_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs, int num)
 	struct i2c_msg *pmsg;
 	int rc = 0, completed = 0, i;
 	struct i2c_pnx_algo_data *alg_data = adap->algo_data;
-	u32 stat = ioread32(I2C_REG_STS(alg_data));
+	u32 stat;
 
 	dev_dbg(&alg_data->adapter.dev,
 		"%s(): entering: %d messages, stat = %04x.\n",
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] i2c: pnx: remove superfluous assignment
  2015-10-25 15:20 [PATCH] i2c: pnx: remove superfluous assignment Wolfram Sang
@ 2015-10-30 11:36 ` Wolfram Sang
  0 siblings, 0 replies; 2+ messages in thread
From: Wolfram Sang @ 2015-10-30 11:36 UTC (permalink / raw)
  To: linux-i2c; +Cc: Vladimir Zapolskiy, Muhammad Falak R Wani, Vitaly Wool

[-- Attachment #1: Type: text/plain, Size: 406 bytes --]

On Sun, Oct 25, 2015 at 04:20:59PM +0100, Wolfram Sang wrote:
> smatch rightfully says:
> 
> drivers/i2c/busses/i2c-pnx.c:499 i2c_pnx_xfer warn: unused return: stat = ioread32()
> 
> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
> Cc: Vladimir Zapolskiy <vz@mleia.com>
> Cc: Muhammad Falak R Wani <falakreyaz@gmail.com>
> Cc: Vitaly Wool <vitalywool@gmail.com>

Applied to for-next, thanks!


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-10-30 11:36 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-25 15:20 [PATCH] i2c: pnx: remove superfluous assignment Wolfram Sang
2015-10-30 11:36 ` Wolfram Sang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).