From: Jeremiah Mahler <jmmahler@gmail.com>
To: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Cc: Olof Johansson <olof@lixom.net>,
linux-kernel@vger.kernel.org, Wolfram Sang <wsa@the-dreams.de>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Dudley Du <dudl@cypress.com>,
linux-i2c@vger.kernel.org
Subject: Re: [PATCH] platform/chrome: Fix i2c-designware adapter name
Date: Tue, 3 Nov 2015 10:49:59 -0800 [thread overview]
Message-ID: <20151103184959.GA4215@newt.localdomain> (raw)
In-Reply-To: <1446548940-19739-1-git-send-email-jarkko.nikula@linux.intel.com>
Jarkko,
On Tue, Nov 03, 2015 at 01:09:00PM +0200, Jarkko Nikula wrote:
> Commit d80d134182ba ("i2c: designware: Move common probe code into
> i2c_dw_probe()") caused the I2C adapter lookup code here to fail for PCI
> enumerated i2c-designware because commit changed the adapter name but
> didn't update it here.
>
> Fix the I2C adapter lookup by using the "Synopsys DesignWare I2C adapter"
> name.
>
> Reported-by: Jeremiah Mahler <jmmahler@gmail.com>
> Fixes: d80d134182ba ("i2c: designware: Move common probe code into i2c_dw_probe()")
> Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
> ---
> Hi Jeremiah. This is the same diff I had in a reply to your bug report.
> Can you test does this fix work for you as I don't have the HW.
> ---
> drivers/platform/chrome/chromeos_laptop.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/platform/chrome/chromeos_laptop.c b/drivers/platform/chrome/chromeos_laptop.c
> index 02072749fff3..2b441e9ae593 100644
> --- a/drivers/platform/chrome/chromeos_laptop.c
> +++ b/drivers/platform/chrome/chromeos_laptop.c
> @@ -47,8 +47,8 @@ static const char *i2c_adapter_names[] = {
> "SMBus I801 adapter",
> "i915 gmbus vga",
> "i915 gmbus panel",
> - "i2c-designware-pci",
> - "i2c-designware-pci",
> + "Synopsys DesignWare I2C adapter",
> + "Synopsys DesignWare I2C adapter",
> };
>
> /* Keep this enum consistent with i2c_adapter_names */
> --
> 2.6.2
>
Yes, this patch fixes the problem.
Tested-by: Jeremiah Mahler <jmmahler@gmail.com>
--
- Jeremiah Mahler
next prev parent reply other threads:[~2015-11-03 18:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-03 11:09 [PATCH] platform/chrome: Fix i2c-designware adapter name Jarkko Nikula
2015-11-03 18:49 ` Jeremiah Mahler [this message]
2015-11-10 3:43 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151103184959.GA4215@newt.localdomain \
--to=jmmahler@gmail.com \
--cc=dudl@cypress.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=olof@lixom.net \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).